Commit 3abc920d authored by Xiubo Li's avatar Xiubo Li Committed by Sasha Levin

regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.

Since we cannot make sure the 'val_count' will always be none zero
here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the zero check before calling
kmemdup().
Signed-off-by: default avatarXiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org

(cherry picked from commit d6b41cb0)
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent cc0ef317
...@@ -1129,6 +1129,9 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val, ...@@ -1129,6 +1129,9 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val,
if (val_bytes == 1) { if (val_bytes == 1) {
wval = (void *)val; wval = (void *)val;
} else { } else {
if (!val_count)
return -EINVAL;
wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL); wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
if (!wval) { if (!wval) {
ret = -ENOMEM; ret = -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment