Commit 3ad2e40a authored by Jake Oshins's avatar Jake Oshins Committed by Tim Gardner

drivers:hv: Track allocations of children of hv_vmbus in private resource tree

BugLink: http://bugs.launchpad.net/bugs/1616677

This patch changes vmbus_allocate_mmio() and vmbus_free_mmio() so
that when child paravirtual devices allocate memory-mapped I/O
space, they allocate it privately from a resource tree pointed
at by hyperv_mmio and also by the public resource tree
iomem_resource.  This allows the region to be marked as "busy"
in the private tree, but a "bridge window" in the public tree,
guaranteeing that no two bridge windows will overlap each other
but while also allowing the PCI device children of the bridge
windows to overlap that window.

One might conclude that this belongs in the pnp layer, rather
than in this driver.  Rafael Wysocki, the maintainter of the
pnp layer, has previously asked that we not modify the pnp layer
as it is considered deprecated.  This patch is thus essentially
a workaround.
Signed-off-by: default avatarJake Oshins <jakeo@microsoft.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit be000f93)
Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
Acked-by: default avatarBrad Figg <brad.figg@canonical.com>
Acked-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 68da7617
...@@ -1164,7 +1164,7 @@ int vmbus_allocate_mmio(struct resource **new, struct hv_device *device_obj, ...@@ -1164,7 +1164,7 @@ int vmbus_allocate_mmio(struct resource **new, struct hv_device *device_obj,
resource_size_t size, resource_size_t align, resource_size_t size, resource_size_t align,
bool fb_overlap_ok) bool fb_overlap_ok)
{ {
struct resource *iter; struct resource *iter, *shadow;
resource_size_t range_min, range_max, start, local_min, local_max; resource_size_t range_min, range_max, start, local_min, local_max;
const char *dev_n = dev_name(&device_obj->device); const char *dev_n = dev_name(&device_obj->device);
u32 fb_end = screen_info.lfb_base + (screen_info.lfb_size << 1); u32 fb_end = screen_info.lfb_base + (screen_info.lfb_size << 1);
...@@ -1226,12 +1226,22 @@ int vmbus_allocate_mmio(struct resource **new, struct hv_device *device_obj, ...@@ -1226,12 +1226,22 @@ int vmbus_allocate_mmio(struct resource **new, struct hv_device *device_obj,
start = (local_min + align - 1) & ~(align - 1); start = (local_min + align - 1) & ~(align - 1);
for (; start + size - 1 <= local_max; start += align) { for (; start + size - 1 <= local_max; start += align) {
shadow = __request_region(iter, start,
size,
NULL,
IORESOURCE_BUSY);
if (!shadow)
continue;
*new = request_mem_region_exclusive(start, size, *new = request_mem_region_exclusive(start, size,
dev_n); dev_n);
if (*new) { if (*new) {
shadow->name = (char *)*new;
retval = 0; retval = 0;
goto exit; goto exit;
} }
__release_region(iter, start, size);
} }
} }
} }
...@@ -1252,7 +1262,17 @@ EXPORT_SYMBOL_GPL(vmbus_allocate_mmio); ...@@ -1252,7 +1262,17 @@ EXPORT_SYMBOL_GPL(vmbus_allocate_mmio);
*/ */
void vmbus_free_mmio(resource_size_t start, resource_size_t size) void vmbus_free_mmio(resource_size_t start, resource_size_t size)
{ {
struct resource *iter;
down(&hyperv_mmio_lock);
for (iter = hyperv_mmio; iter; iter = iter->sibling) {
if ((iter->start >= start + size) || (iter->end <= start))
continue;
__release_region(iter, start, size);
}
release_mem_region(start, size); release_mem_region(start, size);
up(&hyperv_mmio_lock);
} }
EXPORT_SYMBOL_GPL(vmbus_free_mmio); EXPORT_SYMBOL_GPL(vmbus_free_mmio);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment