Commit 3baac729 authored by Rafał Miłecki's avatar Rafał Miłecki Committed by AngeloGioacchino Del Regno

arm64: dts: mediatek: mt2712: fix validation errors

1. Fixup infracfg clock controller binding
   It also acts as reset controller so #reset-cells is required.
2. Use -pins suffix for pinctrl

This fixes:
arch/arm64/boot/dts/mediatek/mt2712-evb.dtb: syscon@10001000: '#reset-cells' is a required property
        from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,infracfg.yaml#
arch/arm64/boot/dts/mediatek/mt2712-evb.dtb: pinctrl@1000b000: 'eth_default', 'eth_sleep', 'usb0_iddig', 'usb1_iddig' do not match any of the regexes: 'pinctrl-[0-9]+', 'pins$'
        from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt65xx-pinctrl.yaml#Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240301074741.8362-1-zajec5@gmail.com
[Angelo: Added Fixes tags]
Fixes: 5d483970 ("arm64: dts: mt2712: Add clock controller device nodes")
Fixes: 1724f4cc ("arm64: dts: Add USB3 related nodes for MT2712")
Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent f8c65a5e
...@@ -129,7 +129,7 @@ ethernet_phy0: ethernet-phy@5 { ...@@ -129,7 +129,7 @@ ethernet_phy0: ethernet-phy@5 {
}; };
&pio { &pio {
eth_default: eth_default { eth_default: eth-default-pins {
tx_pins { tx_pins {
pinmux = <MT2712_PIN_71_GBE_TXD3__FUNC_GBE_TXD3>, pinmux = <MT2712_PIN_71_GBE_TXD3__FUNC_GBE_TXD3>,
<MT2712_PIN_72_GBE_TXD2__FUNC_GBE_TXD2>, <MT2712_PIN_72_GBE_TXD2__FUNC_GBE_TXD2>,
...@@ -156,7 +156,7 @@ mdio_pins { ...@@ -156,7 +156,7 @@ mdio_pins {
}; };
}; };
eth_sleep: eth_sleep { eth_sleep: eth-sleep-pins {
tx_pins { tx_pins {
pinmux = <MT2712_PIN_71_GBE_TXD3__FUNC_GPIO71>, pinmux = <MT2712_PIN_71_GBE_TXD3__FUNC_GPIO71>,
<MT2712_PIN_72_GBE_TXD2__FUNC_GPIO72>, <MT2712_PIN_72_GBE_TXD2__FUNC_GPIO72>,
...@@ -182,14 +182,14 @@ mdio_pins { ...@@ -182,14 +182,14 @@ mdio_pins {
}; };
}; };
usb0_id_pins_float: usb0_iddig { usb0_id_pins_float: usb0-iddig-pins {
pins_iddig { pins_iddig {
pinmux = <MT2712_PIN_12_IDDIG_P0__FUNC_IDDIG_A>; pinmux = <MT2712_PIN_12_IDDIG_P0__FUNC_IDDIG_A>;
bias-pull-up; bias-pull-up;
}; };
}; };
usb1_id_pins_float: usb1_iddig { usb1_id_pins_float: usb1-iddig-pins {
pins_iddig { pins_iddig {
pinmux = <MT2712_PIN_14_IDDIG_P1__FUNC_IDDIG_B>; pinmux = <MT2712_PIN_14_IDDIG_P1__FUNC_IDDIG_B>;
bias-pull-up; bias-pull-up;
......
...@@ -249,10 +249,11 @@ topckgen: syscon@10000000 { ...@@ -249,10 +249,11 @@ topckgen: syscon@10000000 {
#clock-cells = <1>; #clock-cells = <1>;
}; };
infracfg: syscon@10001000 { infracfg: clock-controller@10001000 {
compatible = "mediatek,mt2712-infracfg", "syscon"; compatible = "mediatek,mt2712-infracfg", "syscon";
reg = <0 0x10001000 0 0x1000>; reg = <0 0x10001000 0 0x1000>;
#clock-cells = <1>; #clock-cells = <1>;
#reset-cells = <1>;
}; };
pericfg: syscon@10003000 { pericfg: syscon@10003000 {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment