Commit 3cc33271 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] hugetlbfs cleanups

- Remove quota code.

- Remove extraneous copy-n-paste code from truncate: that's only for
  physically-backed filesystems.

- Whitespace changes.
parent 05732657
...@@ -120,12 +120,14 @@ static int hugetlbfs_readpage(struct file *file, struct page * page) ...@@ -120,12 +120,14 @@ static int hugetlbfs_readpage(struct file *file, struct page * page)
return -EINVAL; return -EINVAL;
} }
static int hugetlbfs_prepare_write(struct file *file, struct page *page, unsigned offset, unsigned to) static int hugetlbfs_prepare_write(struct file *file,
struct page *page, unsigned offset, unsigned to)
{ {
return -EINVAL; return -EINVAL;
} }
static int hugetlbfs_commit_write(struct file *file, struct page *page, unsigned offset, unsigned to) static int hugetlbfs_commit_write(struct file *file,
struct page *page, unsigned offset, unsigned to)
{ {
return -EINVAL; return -EINVAL;
} }
...@@ -140,28 +142,8 @@ void huge_pagevec_release(struct pagevec *pvec) ...@@ -140,28 +142,8 @@ void huge_pagevec_release(struct pagevec *pvec)
pagevec_reinit(pvec); pagevec_reinit(pvec);
} }
void truncate_partial_hugepage(struct page *page, unsigned partial) void truncate_huge_page(struct page *page)
{ {
int i;
const unsigned piece = partial & (PAGE_SIZE - 1);
const unsigned tailstart = PAGE_SIZE - piece;
const unsigned whole_pages = partial / PAGE_SIZE;
const unsigned last_page_offset = HPAGE_SIZE/PAGE_SIZE - whole_pages;
for (i = HPAGE_SIZE/PAGE_SIZE - 1; i >= last_page_offset; ++i)
memclear_highpage_flush(&page[i], 0, PAGE_SIZE);
if (!piece)
return;
memclear_highpage_flush(&page[last_page_offset - 1], tailstart, piece);
}
void truncate_huge_page(struct address_space *mapping, struct page *page)
{
if (page->mapping != mapping)
return;
clear_page_dirty(page); clear_page_dirty(page);
ClearPageUptodate(page); ClearPageUptodate(page);
remove_from_page_cache(page); remove_from_page_cache(page);
...@@ -170,52 +152,13 @@ void truncate_huge_page(struct address_space *mapping, struct page *page) ...@@ -170,52 +152,13 @@ void truncate_huge_page(struct address_space *mapping, struct page *page)
void truncate_hugepages(struct address_space *mapping, loff_t lstart) void truncate_hugepages(struct address_space *mapping, loff_t lstart)
{ {
const pgoff_t start = (lstart + HPAGE_SIZE - 1) >> HPAGE_SHIFT; const pgoff_t start = lstart >> HPAGE_SHIFT;
const unsigned partial = lstart & (HPAGE_SIZE - 1);
struct pagevec pvec; struct pagevec pvec;
pgoff_t next; pgoff_t next;
int i; int i;
pagevec_init(&pvec, 0); pagevec_init(&pvec, 0);
next = start; next = start;
while (pagevec_lookup(&pvec, mapping, next, PAGEVEC_SIZE)) {
for (i = 0; i < pagevec_count(&pvec); ++i) {
struct page *page = pvec.pages[i];
pgoff_t page_index = page->index;
if (page_index > next)
next = page_index;
++next;
if (TestSetPageLocked(page))
continue;
if (PageWriteback(page)) {
unlock_page(page);
continue;
}
truncate_huge_page(mapping, page);
unlock_page(page);
}
huge_pagevec_release(&pvec);
cond_resched();
}
if (partial) {
struct page *page = find_lock_page(mapping, start - 1);
if (page) {
wait_on_page_writeback(page);
truncate_partial_hugepage(page, partial);
unlock_page(page);
huge_page_release(page);
}
}
next = start;
while (1) { while (1) {
if (!pagevec_lookup(&pvec, mapping, next, PAGEVEC_SIZE)) { if (!pagevec_lookup(&pvec, mapping, next, PAGEVEC_SIZE)) {
if (next == start) if (next == start)
...@@ -228,11 +171,10 @@ void truncate_hugepages(struct address_space *mapping, loff_t lstart) ...@@ -228,11 +171,10 @@ void truncate_hugepages(struct address_space *mapping, loff_t lstart)
struct page *page = pvec.pages[i]; struct page *page = pvec.pages[i];
lock_page(page); lock_page(page);
wait_on_page_writeback(page);
if (page->index > next) if (page->index > next)
next = page->index; next = page->index;
++next; ++next;
truncate_huge_page(mapping, page); truncate_huge_page(page);
unlock_page(page); unlock_page(page);
} }
huge_pagevec_release(&pvec); huge_pagevec_release(&pvec);
...@@ -363,13 +305,6 @@ static int hugetlbfs_setattr(struct dentry *dentry, struct iattr *attr) ...@@ -363,13 +305,6 @@ static int hugetlbfs_setattr(struct dentry *dentry, struct iattr *attr)
error = security_inode_setattr(dentry, attr); error = security_inode_setattr(dentry, attr);
if (error) if (error)
goto out; goto out;
if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) ||
(ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid))
error = DQUOT_TRANSFER(inode, attr) ? -EDQUOT : 0;
if (error)
goto out;
if (ia_valid & ATTR_SIZE) { if (ia_valid & ATTR_SIZE) {
error = -EINVAL; error = -EINVAL;
if (!(attr->ia_size & ~HPAGE_MASK)) if (!(attr->ia_size & ~HPAGE_MASK))
...@@ -388,8 +323,8 @@ static int hugetlbfs_setattr(struct dentry *dentry, struct iattr *attr) ...@@ -388,8 +323,8 @@ static int hugetlbfs_setattr(struct dentry *dentry, struct iattr *attr)
return error; return error;
} }
static struct inode * static struct inode *hugetlbfs_get_inode(struct super_block *sb,
hugetlbfs_get_inode(struct super_block *sb, int mode, dev_t dev) int mode, dev_t dev)
{ {
struct inode * inode = new_inode(sb); struct inode * inode = new_inode(sb);
...@@ -401,7 +336,7 @@ hugetlbfs_get_inode(struct super_block *sb, int mode, dev_t dev) ...@@ -401,7 +336,7 @@ hugetlbfs_get_inode(struct super_block *sb, int mode, dev_t dev)
inode->i_blocks = 0; inode->i_blocks = 0;
inode->i_rdev = NODEV; inode->i_rdev = NODEV;
inode->i_mapping->a_ops = &hugetlbfs_aops; inode->i_mapping->a_ops = &hugetlbfs_aops;
inode->i_mapping->backing_dev_info = &hugetlbfs_backing_dev_info; inode->i_mapping->backing_dev_info =&hugetlbfs_backing_dev_info;
inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
switch (mode & S_IFMT) { switch (mode & S_IFMT) {
default: default:
...@@ -430,8 +365,8 @@ hugetlbfs_get_inode(struct super_block *sb, int mode, dev_t dev) ...@@ -430,8 +365,8 @@ hugetlbfs_get_inode(struct super_block *sb, int mode, dev_t dev)
* File creation. Allocate an inode, and we're done.. * File creation. Allocate an inode, and we're done..
*/ */
/* SMP-safe */ /* SMP-safe */
static int static int hugetlbfs_mknod(struct inode *dir,
hugetlbfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev) struct dentry *dentry, int mode, dev_t dev)
{ {
struct inode * inode = hugetlbfs_get_inode(dir->i_sb, mode, dev); struct inode * inode = hugetlbfs_get_inode(dir->i_sb, mode, dev);
int error = -ENOSPC; int error = -ENOSPC;
...@@ -444,7 +379,7 @@ hugetlbfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev) ...@@ -444,7 +379,7 @@ hugetlbfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev)
return error; return error;
} }
static int hugetlbfs_mkdir(struct inode * dir, struct dentry * dentry, int mode) static int hugetlbfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
{ {
int retval = hugetlbfs_mknod(dir, dentry, mode | S_IFDIR, 0); int retval = hugetlbfs_mknod(dir, dentry, mode | S_IFDIR, 0);
if (!retval) if (!retval)
...@@ -457,7 +392,8 @@ static int hugetlbfs_create(struct inode *dir, struct dentry *dentry, int mode) ...@@ -457,7 +392,8 @@ static int hugetlbfs_create(struct inode *dir, struct dentry *dentry, int mode)
return hugetlbfs_mknod(dir, dentry, mode | S_IFREG, 0); return hugetlbfs_mknod(dir, dentry, mode | S_IFREG, 0);
} }
static int hugetlbfs_symlink(struct inode * dir, struct dentry *dentry, const char * symname) static int hugetlbfs_symlink(struct inode *dir,
struct dentry *dentry, const char *symname)
{ {
struct inode *inode; struct inode *inode;
int error = -ENOSPC; int error = -ENOSPC;
...@@ -518,7 +454,8 @@ static struct super_operations hugetlbfs_ops = { ...@@ -518,7 +454,8 @@ static struct super_operations hugetlbfs_ops = {
.drop_inode = hugetlbfs_drop_inode, .drop_inode = hugetlbfs_drop_inode,
}; };
static int hugetlbfs_fill_super(struct super_block * sb, void * data, int silent) static int
hugetlbfs_fill_super(struct super_block * sb, void * data, int silent)
{ {
struct inode * inode; struct inode * inode;
struct dentry * root; struct dentry * root;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment