Commit 3d5cc46e authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nathan Scott

[XFS] Fix O_SYNC flushing in XFS which regressed with concurrent

O_SYNC write improvements recently.
Signed-off-by: default avatarNathan Scott <nathans@sgi.com>
parent 50964d31
...@@ -74,6 +74,7 @@ ...@@ -74,6 +74,7 @@
#include "xfs_iomap.h" #include "xfs_iomap.h"
#include <linux/capability.h> #include <linux/capability.h>
#include <linux/writeback.h>
#if defined(XFS_RW_TRACE) #if defined(XFS_RW_TRACE)
...@@ -871,24 +872,22 @@ xfs_write( ...@@ -871,24 +872,22 @@ xfs_write(
xfs_iunlock(xip, XFS_ILOCK_EXCL); xfs_iunlock(xip, XFS_ILOCK_EXCL);
} }
if (ret <= 0) {
xfs_rwunlock(bdp, locktype);
error = -ret; error = -ret;
goto out_unlock_isem; if (ret <= 0)
} goto out_unlock_internal;
XFS_STATS_ADD(xs_write_bytes, ret); XFS_STATS_ADD(xs_write_bytes, ret);
/* Handle various SYNC-type writes */ /* Handle various SYNC-type writes */
if ((file->f_flags & O_SYNC) || IS_SYNC(file->f_dentry->d_inode)) { if ((file->f_flags & O_SYNC) || IS_SYNC(inode)) {
/* /*
* If we're treating this as O_DSYNC and we have not updated the * If we're treating this as O_DSYNC and we have not updated the
* size, force the log. * size, force the log.
*/ */
if (!(mp->m_flags & XFS_MOUNT_OSYNCISOSYNC) &&
!(xip->i_update_size)) {
xfs_inode_log_item_t *iip = xip->i_itemp;
if (!(mp->m_flags & XFS_MOUNT_OSYNCISOSYNC)
&& !(xip->i_update_size)) {
/* /*
* If an allocation transaction occurred * If an allocation transaction occurred
* without extending the size, then we have to force * without extending the size, then we have to force
...@@ -908,14 +907,8 @@ xfs_write( ...@@ -908,14 +907,8 @@ xfs_write(
* all changes affecting the inode are permanent * all changes affecting the inode are permanent
* when we return. * when we return.
*/ */
xfs_inode_log_item_t *iip;
xfs_lsn_t lsn;
iip = xip->i_itemp;
if (iip && iip->ili_last_lsn) { if (iip && iip->ili_last_lsn) {
lsn = iip->ili_last_lsn; xfs_log_force(mp, iip->ili_last_lsn,
xfs_log_force(mp, lsn,
XFS_LOG_FORCE | XFS_LOG_SYNC); XFS_LOG_FORCE | XFS_LOG_SYNC);
} else if (xfs_ipincount(xip) > 0) { } else if (xfs_ipincount(xip) > 0) {
xfs_log_force(mp, (xfs_lsn_t)0, xfs_log_force(mp, (xfs_lsn_t)0,
...@@ -956,13 +949,21 @@ xfs_write( ...@@ -956,13 +949,21 @@ xfs_write(
xfs_trans_set_sync(tp); xfs_trans_set_sync(tp);
error = xfs_trans_commit(tp, 0, NULL); error = xfs_trans_commit(tp, 0, NULL);
xfs_iunlock(xip, XFS_ILOCK_EXCL); xfs_iunlock(xip, XFS_ILOCK_EXCL);
if (error)
goto out_unlock_internal;
} }
} }
} /* (ioflags & O_SYNC) */
xfs_rwunlock(bdp, locktype); xfs_rwunlock(bdp, locktype);
error = sync_page_range(inode, mapping, pos, ret);
if (!error)
error = -ret; error = -ret;
goto out_unlock_isem;
}
out_unlock_internal:
xfs_rwunlock(bdp, locktype);
out_unlock_isem: out_unlock_isem:
if (need_isem) if (need_isem)
up(&inode->i_sem); up(&inode->i_sem);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment