Commit 4001dfb4 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] cx231xx-i2c: handle errors with cx231xx_get_i2c_adap()

The cx231xx_get_i2c_adap() function should return the I2C
adapter that will be used to talk with a device. It should never
be NULL, as otherwise the driver will try to dereference a
null pointer.

We might instead fix the callers, but if this condition
ever happens, it is really a driver bug, because i2c_port
should always be a value from enum CX231XX_I2C_MASTER_PORT.

Found when checking the code due to this bug:

[   39.769021] BUG: unable to handle kernel NULL pointer dereference at 0000000000000002
[   39.769105] IP: [<ffffffff81638393>] i2c_master_send+0x13/0x70
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 7adc7998
...@@ -608,7 +608,7 @@ struct i2c_adapter *cx231xx_get_i2c_adap(struct cx231xx *dev, int i2c_port) ...@@ -608,7 +608,7 @@ struct i2c_adapter *cx231xx_get_i2c_adap(struct cx231xx *dev, int i2c_port)
case I2C_1_MUX_3: case I2C_1_MUX_3:
return dev->muxc->adapter[1]; return dev->muxc->adapter[1];
default: default:
return NULL; BUG();
} }
} }
EXPORT_SYMBOL_GPL(cx231xx_get_i2c_adap); EXPORT_SYMBOL_GPL(cx231xx_get_i2c_adap);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment