Commit 417b99bf authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski

net: dsa: remove obsolete comments about switchdev transactions

Now that all port object notifiers were converted to be non-transactional,
we can remove the comments that say otherwise.
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1958d581
...@@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev, ...@@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev,
struct dsa_port *dp = dsa_slave_to_port(dev); struct dsa_port *dp = dsa_slave_to_port(dev);
int err; int err;
/* For the prepare phase, ensure the full set of changes is feasable in
* one go in order to signal a failure properly. If an operation is not
* supported, return -EOPNOTSUPP.
*/
switch (obj->id) { switch (obj->id) {
case SWITCHDEV_OBJ_ID_PORT_MDB: case SWITCHDEV_OBJ_ID_PORT_MDB:
if (obj->orig_dev != dev) if (obj->orig_dev != dev)
......
...@@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb, ...@@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb,
break; break;
} }
/* Non-switchdev operations cannot be rolled back. If a DSA driver
* returns an error during the chained call, switch chips may be in an
* inconsistent state.
*/
if (err) if (err)
dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n", dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n",
event, err); event, err);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment