Commit 42a9b766 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

net: nixge: Fix a signedness bug in nixge_probe()

[ Upstream commit 1a4b62a0 ]

The "priv->phy_mode" is an enum and in this context GCC will treat it
as an unsigned int so it can never be less than zero.

Fixes: 492caffa ("net: ethernet: nixge: Add support for National Instruments XGE netdev")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent aa08e30c
...@@ -1233,7 +1233,7 @@ static int nixge_probe(struct platform_device *pdev) ...@@ -1233,7 +1233,7 @@ static int nixge_probe(struct platform_device *pdev)
} }
priv->phy_mode = of_get_phy_mode(pdev->dev.of_node); priv->phy_mode = of_get_phy_mode(pdev->dev.of_node);
if (priv->phy_mode < 0) { if ((int)priv->phy_mode < 0) {
netdev_err(ndev, "not find \"phy-mode\" property\n"); netdev_err(ndev, "not find \"phy-mode\" property\n");
err = -EINVAL; err = -EINVAL;
goto unregister_mdio; goto unregister_mdio;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment