Commit 4773c1ee authored by Guenter Roeck's avatar Guenter Roeck Committed by Kleber Sacilotto de Souza

kobject: Replace strncpy with memcpy

BugLink: https://bugs.launchpad.net/bugs/1811077

commit 77d2a24b upstream.

gcc 8.1.0 complains:

lib/kobject.c:128:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length [-Wstringop-truncation]
lib/kobject.c: In function 'kobject_get_path':
lib/kobject.c:125:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJuerg Haefliger <juergh@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 1cf7bce6
...@@ -127,7 +127,7 @@ static void fill_kobj_path(struct kobject *kobj, char *path, int length) ...@@ -127,7 +127,7 @@ static void fill_kobj_path(struct kobject *kobj, char *path, int length)
int cur = strlen(kobject_name(parent)); int cur = strlen(kobject_name(parent));
/* back up enough to print this name with '/' */ /* back up enough to print this name with '/' */
length -= cur; length -= cur;
strncpy(path + length, kobject_name(parent), cur); memcpy(path + length, kobject_name(parent), cur);
*(path + --length) = '/'; *(path + --length) = '/';
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment