Commit 49e22632 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mark Brown

regulator: Reverse the disable sequence in regulator_bulk_disable()

Often there is a need for disabling a set of regulators in order opposite
to the enable order. Currently the function regulator_bulk_disable() walks
list of regulators in same order as regulator_bulk_enable(). This may cause
trouble, especially for devices with mixed analogue and digital circuits.
So reverse the disabling sequence of regulator_bulk_disable().
While at it, also correct the comment.
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent dcd6c922
...@@ -2463,8 +2463,8 @@ EXPORT_SYMBOL_GPL(regulator_bulk_enable); ...@@ -2463,8 +2463,8 @@ EXPORT_SYMBOL_GPL(regulator_bulk_enable);
* @return 0 on success, an errno on failure * @return 0 on success, an errno on failure
* *
* This convenience API allows consumers to disable multiple regulator * This convenience API allows consumers to disable multiple regulator
* clients in a single API call. If any consumers cannot be enabled * clients in a single API call. If any consumers cannot be disabled
* then any others that were disabled will be disabled again prior to * then any others that were disabled will be enabled again prior to
* return. * return.
*/ */
int regulator_bulk_disable(int num_consumers, int regulator_bulk_disable(int num_consumers,
...@@ -2473,7 +2473,7 @@ int regulator_bulk_disable(int num_consumers, ...@@ -2473,7 +2473,7 @@ int regulator_bulk_disable(int num_consumers,
int i; int i;
int ret; int ret;
for (i = 0; i < num_consumers; i++) { for (i = num_consumers - 1; i >= 0; --i) {
ret = regulator_disable(consumers[i].consumer); ret = regulator_disable(consumers[i].consumer);
if (ret != 0) if (ret != 0)
goto err; goto err;
...@@ -2483,7 +2483,7 @@ int regulator_bulk_disable(int num_consumers, ...@@ -2483,7 +2483,7 @@ int regulator_bulk_disable(int num_consumers,
err: err:
pr_err("Failed to disable %s: %d\n", consumers[i].supply, ret); pr_err("Failed to disable %s: %d\n", consumers[i].supply, ret);
for (--i; i >= 0; --i) for (++i; i < num_consumers; ++i)
regulator_enable(consumers[i].consumer); regulator_enable(consumers[i].consumer);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment