Commit 4c529900 authored by Chris Mason's avatar Chris Mason

Merge branch 'for-chris' of...

Merge branch 'for-chris' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.7
parents 8dff9c85 34b3e6c9
...@@ -1373,7 +1373,8 @@ tree_mod_log_rewind(struct btrfs_fs_info *fs_info, struct btrfs_path *path, ...@@ -1373,7 +1373,8 @@ tree_mod_log_rewind(struct btrfs_fs_info *fs_info, struct btrfs_path *path,
if (tm->op == MOD_LOG_KEY_REMOVE_WHILE_FREEING) { if (tm->op == MOD_LOG_KEY_REMOVE_WHILE_FREEING) {
BUG_ON(tm->slot != 0); BUG_ON(tm->slot != 0);
eb_rewin = alloc_dummy_extent_buffer(fs_info, eb->start); eb_rewin = alloc_dummy_extent_buffer(fs_info, eb->start,
eb->len);
if (!eb_rewin) { if (!eb_rewin) {
btrfs_tree_read_unlock_blocking(eb); btrfs_tree_read_unlock_blocking(eb);
free_extent_buffer(eb); free_extent_buffer(eb);
...@@ -1454,7 +1455,8 @@ get_old_root(struct btrfs_root *root, u64 time_seq) ...@@ -1454,7 +1455,8 @@ get_old_root(struct btrfs_root *root, u64 time_seq)
} else if (old_root) { } else if (old_root) {
btrfs_tree_read_unlock(eb_root); btrfs_tree_read_unlock(eb_root);
free_extent_buffer(eb_root); free_extent_buffer(eb_root);
eb = alloc_dummy_extent_buffer(root->fs_info, logical); eb = alloc_dummy_extent_buffer(root->fs_info, logical,
root->nodesize);
} else { } else {
btrfs_set_lock_blocking_rw(eb_root, BTRFS_READ_LOCK); btrfs_set_lock_blocking_rw(eb_root, BTRFS_READ_LOCK);
eb = btrfs_clone_extent_buffer(eb_root); eb = btrfs_clone_extent_buffer(eb_root);
......
...@@ -1147,7 +1147,8 @@ struct extent_buffer *btrfs_find_create_tree_block(struct btrfs_root *root, ...@@ -1147,7 +1147,8 @@ struct extent_buffer *btrfs_find_create_tree_block(struct btrfs_root *root,
u64 bytenr) u64 bytenr)
{ {
if (btrfs_test_is_dummy_root(root)) if (btrfs_test_is_dummy_root(root))
return alloc_test_extent_buffer(root->fs_info, bytenr); return alloc_test_extent_buffer(root->fs_info, bytenr,
root->nodesize);
return alloc_extent_buffer(root->fs_info, bytenr); return alloc_extent_buffer(root->fs_info, bytenr);
} }
...@@ -1314,14 +1315,16 @@ static struct btrfs_root *btrfs_alloc_root(struct btrfs_fs_info *fs_info, ...@@ -1314,14 +1315,16 @@ static struct btrfs_root *btrfs_alloc_root(struct btrfs_fs_info *fs_info,
#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS #ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
/* Should only be used by the testing infrastructure */ /* Should only be used by the testing infrastructure */
struct btrfs_root *btrfs_alloc_dummy_root(void) struct btrfs_root *btrfs_alloc_dummy_root(u32 sectorsize, u32 nodesize)
{ {
struct btrfs_root *root; struct btrfs_root *root;
root = btrfs_alloc_root(NULL, GFP_KERNEL); root = btrfs_alloc_root(NULL, GFP_KERNEL);
if (!root) if (!root)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
__setup_root(4096, 4096, 4096, root, NULL, 1); /* We don't use the stripesize in selftest, set it as sectorsize */
__setup_root(nodesize, sectorsize, sectorsize, root, NULL,
BTRFS_ROOT_TREE_OBJECTID);
set_bit(BTRFS_ROOT_DUMMY_ROOT, &root->state); set_bit(BTRFS_ROOT_DUMMY_ROOT, &root->state);
root->alloc_bytenr = 0; root->alloc_bytenr = 0;
......
...@@ -90,7 +90,7 @@ void btrfs_drop_and_free_fs_root(struct btrfs_fs_info *fs_info, ...@@ -90,7 +90,7 @@ void btrfs_drop_and_free_fs_root(struct btrfs_fs_info *fs_info,
void btrfs_free_fs_root(struct btrfs_root *root); void btrfs_free_fs_root(struct btrfs_root *root);
#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS #ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
struct btrfs_root *btrfs_alloc_dummy_root(void); struct btrfs_root *btrfs_alloc_dummy_root(u32 sectorsize, u32 nodesize);
#endif #endif
/* /*
......
...@@ -4728,16 +4728,16 @@ struct extent_buffer *__alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info, ...@@ -4728,16 +4728,16 @@ struct extent_buffer *__alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info,
} }
struct extent_buffer *alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info, struct extent_buffer *alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info,
u64 start) u64 start, u32 nodesize)
{ {
unsigned long len; unsigned long len;
if (!fs_info) { if (!fs_info) {
/* /*
* Called only from tests that don't always have a fs_info * Called only from tests that don't always have a fs_info
* available, but we know that nodesize is 4096 * available
*/ */
len = 4096; len = nodesize;
} else { } else {
len = fs_info->tree_root->nodesize; len = fs_info->tree_root->nodesize;
} }
...@@ -4833,7 +4833,7 @@ struct extent_buffer *find_extent_buffer(struct btrfs_fs_info *fs_info, ...@@ -4833,7 +4833,7 @@ struct extent_buffer *find_extent_buffer(struct btrfs_fs_info *fs_info,
#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS #ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info, struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info,
u64 start) u64 start, u32 nodesize)
{ {
struct extent_buffer *eb, *exists = NULL; struct extent_buffer *eb, *exists = NULL;
int ret; int ret;
...@@ -4841,7 +4841,7 @@ struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info, ...@@ -4841,7 +4841,7 @@ struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info,
eb = find_extent_buffer(fs_info, start); eb = find_extent_buffer(fs_info, start);
if (eb) if (eb)
return eb; return eb;
eb = alloc_dummy_extent_buffer(fs_info, start); eb = alloc_dummy_extent_buffer(fs_info, start, nodesize);
if (!eb) if (!eb)
return NULL; return NULL;
eb->fs_info = fs_info; eb->fs_info = fs_info;
......
...@@ -348,7 +348,7 @@ struct extent_buffer *alloc_extent_buffer(struct btrfs_fs_info *fs_info, ...@@ -348,7 +348,7 @@ struct extent_buffer *alloc_extent_buffer(struct btrfs_fs_info *fs_info,
struct extent_buffer *__alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info, struct extent_buffer *__alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info,
u64 start, unsigned long len); u64 start, unsigned long len);
struct extent_buffer *alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info, struct extent_buffer *alloc_dummy_extent_buffer(struct btrfs_fs_info *fs_info,
u64 start); u64 start, u32 nodesize);
struct extent_buffer *btrfs_clone_extent_buffer(struct extent_buffer *src); struct extent_buffer *btrfs_clone_extent_buffer(struct extent_buffer *src);
struct extent_buffer *find_extent_buffer(struct btrfs_fs_info *fs_info, struct extent_buffer *find_extent_buffer(struct btrfs_fs_info *fs_info,
u64 start); u64 start);
...@@ -468,5 +468,5 @@ noinline u64 find_lock_delalloc_range(struct inode *inode, ...@@ -468,5 +468,5 @@ noinline u64 find_lock_delalloc_range(struct inode *inode,
u64 *end, u64 max_bytes); u64 *end, u64 max_bytes);
#endif #endif
struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info, struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info,
u64 start); u64 start, u32 nodesize);
#endif #endif
...@@ -29,7 +29,7 @@ ...@@ -29,7 +29,7 @@
#include "inode-map.h" #include "inode-map.h"
#include "volumes.h" #include "volumes.h"
#define BITS_PER_BITMAP (PAGE_SIZE * 8) #define BITS_PER_BITMAP (PAGE_SIZE * 8UL)
#define MAX_CACHE_BYTES_PER_GIG SZ_32K #define MAX_CACHE_BYTES_PER_GIG SZ_32K
struct btrfs_trim_range { struct btrfs_trim_range {
...@@ -1415,11 +1415,11 @@ static inline u64 offset_to_bitmap(struct btrfs_free_space_ctl *ctl, ...@@ -1415,11 +1415,11 @@ static inline u64 offset_to_bitmap(struct btrfs_free_space_ctl *ctl,
u64 offset) u64 offset)
{ {
u64 bitmap_start; u64 bitmap_start;
u32 bytes_per_bitmap; u64 bytes_per_bitmap;
bytes_per_bitmap = BITS_PER_BITMAP * ctl->unit; bytes_per_bitmap = BITS_PER_BITMAP * ctl->unit;
bitmap_start = offset - ctl->start; bitmap_start = offset - ctl->start;
bitmap_start = div_u64(bitmap_start, bytes_per_bitmap); bitmap_start = div64_u64(bitmap_start, bytes_per_bitmap);
bitmap_start *= bytes_per_bitmap; bitmap_start *= bytes_per_bitmap;
bitmap_start += ctl->start; bitmap_start += ctl->start;
...@@ -1638,10 +1638,10 @@ static void recalculate_thresholds(struct btrfs_free_space_ctl *ctl) ...@@ -1638,10 +1638,10 @@ static void recalculate_thresholds(struct btrfs_free_space_ctl *ctl)
u64 bitmap_bytes; u64 bitmap_bytes;
u64 extent_bytes; u64 extent_bytes;
u64 size = block_group->key.offset; u64 size = block_group->key.offset;
u32 bytes_per_bg = BITS_PER_BITMAP * ctl->unit; u64 bytes_per_bg = BITS_PER_BITMAP * ctl->unit;
u32 max_bitmaps = div_u64(size + bytes_per_bg - 1, bytes_per_bg); u64 max_bitmaps = div64_u64(size + bytes_per_bg - 1, bytes_per_bg);
max_bitmaps = max_t(u32, max_bitmaps, 1); max_bitmaps = max_t(u64, max_bitmaps, 1);
ASSERT(ctl->total_bitmaps <= max_bitmaps); ASSERT(ctl->total_bitmaps <= max_bitmaps);
...@@ -1660,7 +1660,7 @@ static void recalculate_thresholds(struct btrfs_free_space_ctl *ctl) ...@@ -1660,7 +1660,7 @@ static void recalculate_thresholds(struct btrfs_free_space_ctl *ctl)
* sure we don't go over our overall goal of MAX_CACHE_BYTES_PER_GIG as * sure we don't go over our overall goal of MAX_CACHE_BYTES_PER_GIG as
* we add more bitmaps. * we add more bitmaps.
*/ */
bitmap_bytes = (ctl->total_bitmaps + 1) * PAGE_SIZE; bitmap_bytes = (ctl->total_bitmaps + 1) * ctl->unit;
if (bitmap_bytes >= max_bytes) { if (bitmap_bytes >= max_bytes) {
ctl->extents_thresh = 0; ctl->extents_thresh = 0;
...@@ -3662,7 +3662,7 @@ int test_check_exists(struct btrfs_block_group_cache *cache, ...@@ -3662,7 +3662,7 @@ int test_check_exists(struct btrfs_block_group_cache *cache,
if (tmp->offset + tmp->bytes < offset) if (tmp->offset + tmp->bytes < offset)
break; break;
if (offset + bytes < tmp->offset) { if (offset + bytes < tmp->offset) {
n = rb_prev(&info->offset_index); n = rb_prev(&tmp->offset_index);
continue; continue;
} }
info = tmp; info = tmp;
...@@ -3676,7 +3676,7 @@ int test_check_exists(struct btrfs_block_group_cache *cache, ...@@ -3676,7 +3676,7 @@ int test_check_exists(struct btrfs_block_group_cache *cache,
if (offset + bytes < tmp->offset) if (offset + bytes < tmp->offset)
break; break;
if (tmp->offset + tmp->bytes < offset) { if (tmp->offset + tmp->bytes < offset) {
n = rb_next(&info->offset_index); n = rb_next(&tmp->offset_index);
continue; continue;
} }
info = tmp; info = tmp;
......
...@@ -2318,28 +2318,42 @@ static void btrfs_print_mod_info(void) ...@@ -2318,28 +2318,42 @@ static void btrfs_print_mod_info(void)
static int btrfs_run_sanity_tests(void) static int btrfs_run_sanity_tests(void)
{ {
int ret; int ret, i;
u32 sectorsize, nodesize;
u32 test_sectorsize[] = {
PAGE_SIZE,
};
ret = btrfs_init_test_fs(); ret = btrfs_init_test_fs();
if (ret) if (ret)
return ret; return ret;
for (i = 0; i < ARRAY_SIZE(test_sectorsize); i++) {
ret = btrfs_test_free_space_cache(); sectorsize = test_sectorsize[i];
for (nodesize = sectorsize;
nodesize <= BTRFS_MAX_METADATA_BLOCKSIZE;
nodesize <<= 1) {
pr_info("BTRFS: selftest: sectorsize: %u nodesize: %u\n",
sectorsize, nodesize);
ret = btrfs_test_free_space_cache(sectorsize, nodesize);
if (ret) if (ret)
goto out; goto out;
ret = btrfs_test_extent_buffer_operations(); ret = btrfs_test_extent_buffer_operations(sectorsize,
nodesize);
if (ret) if (ret)
goto out; goto out;
ret = btrfs_test_extent_io(); ret = btrfs_test_extent_io(sectorsize, nodesize);
if (ret) if (ret)
goto out; goto out;
ret = btrfs_test_inodes(); ret = btrfs_test_inodes(sectorsize, nodesize);
if (ret) if (ret)
goto out; goto out;
ret = btrfs_test_qgroups(); ret = btrfs_test_qgroups(sectorsize, nodesize);
if (ret) if (ret)
goto out; goto out;
ret = btrfs_test_free_space_tree(); ret = btrfs_test_free_space_tree(sectorsize, nodesize);
if (ret)
goto out;
}
}
out: out:
btrfs_destroy_test_fs(); btrfs_destroy_test_fs();
return ret; return ret;
......
...@@ -175,7 +175,7 @@ void btrfs_free_dummy_root(struct btrfs_root *root) ...@@ -175,7 +175,7 @@ void btrfs_free_dummy_root(struct btrfs_root *root)
} }
struct btrfs_block_group_cache * struct btrfs_block_group_cache *
btrfs_alloc_dummy_block_group(unsigned long length) btrfs_alloc_dummy_block_group(unsigned long length, u32 sectorsize)
{ {
struct btrfs_block_group_cache *cache; struct btrfs_block_group_cache *cache;
...@@ -192,8 +192,8 @@ btrfs_alloc_dummy_block_group(unsigned long length) ...@@ -192,8 +192,8 @@ btrfs_alloc_dummy_block_group(unsigned long length)
cache->key.objectid = 0; cache->key.objectid = 0;
cache->key.offset = length; cache->key.offset = length;
cache->key.type = BTRFS_BLOCK_GROUP_ITEM_KEY; cache->key.type = BTRFS_BLOCK_GROUP_ITEM_KEY;
cache->sectorsize = 4096; cache->sectorsize = sectorsize;
cache->full_stripe_len = 4096; cache->full_stripe_len = sectorsize;
INIT_LIST_HEAD(&cache->list); INIT_LIST_HEAD(&cache->list);
INIT_LIST_HEAD(&cache->cluster_list); INIT_LIST_HEAD(&cache->cluster_list);
......
...@@ -26,27 +26,28 @@ ...@@ -26,27 +26,28 @@
struct btrfs_root; struct btrfs_root;
struct btrfs_trans_handle; struct btrfs_trans_handle;
int btrfs_test_free_space_cache(void); int btrfs_test_free_space_cache(u32 sectorsize, u32 nodesize);
int btrfs_test_extent_buffer_operations(void); int btrfs_test_extent_buffer_operations(u32 sectorsize, u32 nodesize);
int btrfs_test_extent_io(void); int btrfs_test_extent_io(u32 sectorsize, u32 nodesize);
int btrfs_test_inodes(void); int btrfs_test_inodes(u32 sectorsize, u32 nodesize);
int btrfs_test_qgroups(void); int btrfs_test_qgroups(u32 sectorsize, u32 nodesize);
int btrfs_test_free_space_tree(void); int btrfs_test_free_space_tree(u32 sectorsize, u32 nodesize);
int btrfs_init_test_fs(void); int btrfs_init_test_fs(void);
void btrfs_destroy_test_fs(void); void btrfs_destroy_test_fs(void);
struct inode *btrfs_new_test_inode(void); struct inode *btrfs_new_test_inode(void);
struct btrfs_fs_info *btrfs_alloc_dummy_fs_info(void); struct btrfs_fs_info *btrfs_alloc_dummy_fs_info(void);
void btrfs_free_dummy_root(struct btrfs_root *root); void btrfs_free_dummy_root(struct btrfs_root *root);
struct btrfs_block_group_cache * struct btrfs_block_group_cache *
btrfs_alloc_dummy_block_group(unsigned long length); btrfs_alloc_dummy_block_group(unsigned long length, u32 sectorsize);
void btrfs_free_dummy_block_group(struct btrfs_block_group_cache *cache); void btrfs_free_dummy_block_group(struct btrfs_block_group_cache *cache);
void btrfs_init_dummy_trans(struct btrfs_trans_handle *trans); void btrfs_init_dummy_trans(struct btrfs_trans_handle *trans);
#else #else
static inline int btrfs_test_free_space_cache(void) static inline int btrfs_test_free_space_cache(u32 sectorsize, u32 nodesize)
{ {
return 0; return 0;
} }
static inline int btrfs_test_extent_buffer_operations(void) static inline int btrfs_test_extent_buffer_operations(u32 sectorsize,
u32 nodesize)
{ {
return 0; return 0;
} }
...@@ -57,19 +58,19 @@ static inline int btrfs_init_test_fs(void) ...@@ -57,19 +58,19 @@ static inline int btrfs_init_test_fs(void)
static inline void btrfs_destroy_test_fs(void) static inline void btrfs_destroy_test_fs(void)
{ {
} }
static inline int btrfs_test_extent_io(void) static inline int btrfs_test_extent_io(u32 sectorsize, u32 nodesize)
{ {
return 0; return 0;
} }
static inline int btrfs_test_inodes(void) static inline int btrfs_test_inodes(u32 sectorsize, u32 nodesize)
{ {
return 0; return 0;
} }
static inline int btrfs_test_qgroups(void) static inline int btrfs_test_qgroups(u32 sectorsize, u32 nodesize)
{ {
return 0; return 0;
} }
static inline int btrfs_test_free_space_tree(void) static inline int btrfs_test_free_space_tree(u32 sectorsize, u32 nodesize)
{ {
return 0; return 0;
} }
......
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
#include "../extent_io.h" #include "../extent_io.h"
#include "../disk-io.h" #include "../disk-io.h"
static int test_btrfs_split_item(void) static int test_btrfs_split_item(u32 sectorsize, u32 nodesize)
{ {
struct btrfs_path *path; struct btrfs_path *path;
struct btrfs_root *root; struct btrfs_root *root;
...@@ -40,7 +40,7 @@ static int test_btrfs_split_item(void) ...@@ -40,7 +40,7 @@ static int test_btrfs_split_item(void)
test_msg("Running btrfs_split_item tests\n"); test_msg("Running btrfs_split_item tests\n");
root = btrfs_alloc_dummy_root(); root = btrfs_alloc_dummy_root(sectorsize, nodesize);
if (IS_ERR(root)) { if (IS_ERR(root)) {
test_msg("Could not allocate root\n"); test_msg("Could not allocate root\n");
return PTR_ERR(root); return PTR_ERR(root);
...@@ -53,7 +53,8 @@ static int test_btrfs_split_item(void) ...@@ -53,7 +53,8 @@ static int test_btrfs_split_item(void)
return -ENOMEM; return -ENOMEM;
} }
path->nodes[0] = eb = alloc_dummy_extent_buffer(NULL, 4096); path->nodes[0] = eb = alloc_dummy_extent_buffer(NULL, nodesize,
nodesize);
if (!eb) { if (!eb) {
test_msg("Could not allocate dummy buffer\n"); test_msg("Could not allocate dummy buffer\n");
ret = -ENOMEM; ret = -ENOMEM;
...@@ -222,8 +223,8 @@ static int test_btrfs_split_item(void) ...@@ -222,8 +223,8 @@ static int test_btrfs_split_item(void)
return ret; return ret;
} }
int btrfs_test_extent_buffer_operations(void) int btrfs_test_extent_buffer_operations(u32 sectorsize, u32 nodesize)
{ {
test_msg("Running extent buffer operation tests"); test_msg("Running extent buffer operation tests\n");
return test_btrfs_split_item(); return test_btrfs_split_item(sectorsize, nodesize);
} }
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/sizes.h> #include <linux/sizes.h>
#include "btrfs-tests.h" #include "btrfs-tests.h"
#include "../ctree.h"
#include "../extent_io.h" #include "../extent_io.h"
#define PROCESS_UNLOCK (1 << 0) #define PROCESS_UNLOCK (1 << 0)
...@@ -65,7 +66,7 @@ static noinline int process_page_range(struct inode *inode, u64 start, u64 end, ...@@ -65,7 +66,7 @@ static noinline int process_page_range(struct inode *inode, u64 start, u64 end,
return count; return count;
} }
static int test_find_delalloc(void) static int test_find_delalloc(u32 sectorsize)
{ {
struct inode *inode; struct inode *inode;
struct extent_io_tree tmp; struct extent_io_tree tmp;
...@@ -113,7 +114,7 @@ static int test_find_delalloc(void) ...@@ -113,7 +114,7 @@ static int test_find_delalloc(void)
* |--- delalloc ---| * |--- delalloc ---|
* |--- search ---| * |--- search ---|
*/ */
set_extent_delalloc(&tmp, 0, 4095, NULL); set_extent_delalloc(&tmp, 0, sectorsize - 1, NULL);
start = 0; start = 0;
end = 0; end = 0;
found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
...@@ -122,9 +123,9 @@ static int test_find_delalloc(void) ...@@ -122,9 +123,9 @@ static int test_find_delalloc(void)
test_msg("Should have found at least one delalloc\n"); test_msg("Should have found at least one delalloc\n");
goto out_bits; goto out_bits;
} }
if (start != 0 || end != 4095) { if (start != 0 || end != (sectorsize - 1)) {
test_msg("Expected start 0 end 4095, got start %Lu end %Lu\n", test_msg("Expected start 0 end %u, got start %llu end %llu\n",
start, end); sectorsize - 1, start, end);
goto out_bits; goto out_bits;
} }
unlock_extent(&tmp, start, end); unlock_extent(&tmp, start, end);
...@@ -144,7 +145,7 @@ static int test_find_delalloc(void) ...@@ -144,7 +145,7 @@ static int test_find_delalloc(void)
test_msg("Couldn't find the locked page\n"); test_msg("Couldn't find the locked page\n");
goto out_bits; goto out_bits;
} }
set_extent_delalloc(&tmp, 4096, max_bytes - 1, NULL); set_extent_delalloc(&tmp, sectorsize, max_bytes - 1, NULL);
start = test_start; start = test_start;
end = 0; end = 0;
found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, found = find_lock_delalloc_range(inode, &tmp, locked_page, &start,
...@@ -172,7 +173,7 @@ static int test_find_delalloc(void) ...@@ -172,7 +173,7 @@ static int test_find_delalloc(void)
* |--- delalloc ---| * |--- delalloc ---|
* |--- search ---| * |--- search ---|
*/ */
test_start = max_bytes + 4096; test_start = max_bytes + sectorsize;
locked_page = find_lock_page(inode->i_mapping, test_start >> locked_page = find_lock_page(inode->i_mapping, test_start >>
PAGE_SHIFT); PAGE_SHIFT);
if (!locked_page) { if (!locked_page) {
...@@ -272,6 +273,16 @@ static int test_find_delalloc(void) ...@@ -272,6 +273,16 @@ static int test_find_delalloc(void)
return ret; return ret;
} }
/**
* test_bit_in_byte - Determine whether a bit is set in a byte
* @nr: bit number to test
* @addr: Address to start counting from
*/
static inline int test_bit_in_byte(int nr, const u8 *addr)
{
return 1UL & (addr[nr / BITS_PER_BYTE] >> (nr & (BITS_PER_BYTE - 1)));
}
static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb, static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb,
unsigned long len) unsigned long len)
{ {
...@@ -298,7 +309,10 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb, ...@@ -298,7 +309,10 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb,
return -EINVAL; return -EINVAL;
} }
bitmap_set(bitmap, (PAGE_SIZE - sizeof(long) / 2) * BITS_PER_BYTE, /* Straddling pages test */
if (len > PAGE_SIZE) {
bitmap_set(bitmap,
(PAGE_SIZE - sizeof(long) / 2) * BITS_PER_BYTE,
sizeof(long) * BITS_PER_BYTE); sizeof(long) * BITS_PER_BYTE);
extent_buffer_bitmap_set(eb, PAGE_SIZE - sizeof(long) / 2, 0, extent_buffer_bitmap_set(eb, PAGE_SIZE - sizeof(long) / 2, 0,
sizeof(long) * BITS_PER_BYTE); sizeof(long) * BITS_PER_BYTE);
...@@ -318,6 +332,7 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb, ...@@ -318,6 +332,7 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb,
test_msg("Clearing straddling pages failed\n"); test_msg("Clearing straddling pages failed\n");
return -EINVAL; return -EINVAL;
} }
}
/* /*
* Generate a wonky pseudo-random bit pattern for the sake of not using * Generate a wonky pseudo-random bit pattern for the sake of not using
...@@ -333,7 +348,7 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb, ...@@ -333,7 +348,7 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb,
for (i = 0; i < len * BITS_PER_BYTE; i++) { for (i = 0; i < len * BITS_PER_BYTE; i++) {
int bit, bit1; int bit, bit1;
bit = !!test_bit(i, bitmap); bit = !!test_bit_in_byte(i, (u8 *)bitmap);
bit1 = !!extent_buffer_test_bit(eb, 0, i); bit1 = !!extent_buffer_test_bit(eb, 0, i);
if (bit1 != bit) { if (bit1 != bit) {
test_msg("Testing bit pattern failed\n"); test_msg("Testing bit pattern failed\n");
...@@ -351,15 +366,22 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb, ...@@ -351,15 +366,22 @@ static int __test_eb_bitmaps(unsigned long *bitmap, struct extent_buffer *eb,
return 0; return 0;
} }
static int test_eb_bitmaps(void) static int test_eb_bitmaps(u32 sectorsize, u32 nodesize)
{ {
unsigned long len = PAGE_SIZE * 4; unsigned long len;
unsigned long *bitmap; unsigned long *bitmap;
struct extent_buffer *eb; struct extent_buffer *eb;
int ret; int ret;
test_msg("Running extent buffer bitmap tests\n"); test_msg("Running extent buffer bitmap tests\n");
/*
* In ppc64, sectorsize can be 64K, thus 4 * 64K will be larger than
* BTRFS_MAX_METADATA_BLOCKSIZE.
*/
len = (sectorsize < BTRFS_MAX_METADATA_BLOCKSIZE)
? sectorsize * 4 : sectorsize;
bitmap = kmalloc(len, GFP_KERNEL); bitmap = kmalloc(len, GFP_KERNEL);
if (!bitmap) { if (!bitmap) {
test_msg("Couldn't allocate test bitmap\n"); test_msg("Couldn't allocate test bitmap\n");
...@@ -379,7 +401,7 @@ static int test_eb_bitmaps(void) ...@@ -379,7 +401,7 @@ static int test_eb_bitmaps(void)
/* Do it over again with an extent buffer which isn't page-aligned. */ /* Do it over again with an extent buffer which isn't page-aligned. */
free_extent_buffer(eb); free_extent_buffer(eb);
eb = __alloc_dummy_extent_buffer(NULL, PAGE_SIZE / 2, len); eb = __alloc_dummy_extent_buffer(NULL, nodesize / 2, len);
if (!eb) { if (!eb) {
test_msg("Couldn't allocate test extent buffer\n"); test_msg("Couldn't allocate test extent buffer\n");
kfree(bitmap); kfree(bitmap);
...@@ -393,17 +415,17 @@ static int test_eb_bitmaps(void) ...@@ -393,17 +415,17 @@ static int test_eb_bitmaps(void)
return ret; return ret;
} }
int btrfs_test_extent_io(void) int btrfs_test_extent_io(u32 sectorsize, u32 nodesize)
{ {
int ret; int ret;
test_msg("Running extent I/O tests\n"); test_msg("Running extent I/O tests\n");
ret = test_find_delalloc(); ret = test_find_delalloc(sectorsize);
if (ret) if (ret)
goto out; goto out;
ret = test_eb_bitmaps(); ret = test_eb_bitmaps(sectorsize, nodesize);
out: out:
test_msg("Extent I/O tests finished\n"); test_msg("Extent I/O tests finished\n");
return ret; return ret;
......
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
#include "../disk-io.h" #include "../disk-io.h"
#include "../free-space-cache.h" #include "../free-space-cache.h"
#define BITS_PER_BITMAP (PAGE_SIZE * 8) #define BITS_PER_BITMAP (PAGE_SIZE * 8UL)
/* /*
* This test just does basic sanity checking, making sure we can add an extent * This test just does basic sanity checking, making sure we can add an extent
...@@ -99,7 +99,8 @@ static int test_extents(struct btrfs_block_group_cache *cache) ...@@ -99,7 +99,8 @@ static int test_extents(struct btrfs_block_group_cache *cache)
return 0; return 0;
} }
static int test_bitmaps(struct btrfs_block_group_cache *cache) static int test_bitmaps(struct btrfs_block_group_cache *cache,
u32 sectorsize)
{ {
u64 next_bitmap_offset; u64 next_bitmap_offset;
int ret; int ret;
...@@ -139,7 +140,7 @@ static int test_bitmaps(struct btrfs_block_group_cache *cache) ...@@ -139,7 +140,7 @@ static int test_bitmaps(struct btrfs_block_group_cache *cache)
* The first bitmap we have starts at offset 0 so the next one is just * The first bitmap we have starts at offset 0 so the next one is just
* at the end of the first bitmap. * at the end of the first bitmap.
*/ */
next_bitmap_offset = (u64)(BITS_PER_BITMAP * 4096); next_bitmap_offset = (u64)(BITS_PER_BITMAP * sectorsize);
/* Test a bit straddling two bitmaps */ /* Test a bit straddling two bitmaps */
ret = test_add_free_space_entry(cache, next_bitmap_offset - SZ_2M, ret = test_add_free_space_entry(cache, next_bitmap_offset - SZ_2M,
...@@ -167,9 +168,10 @@ static int test_bitmaps(struct btrfs_block_group_cache *cache) ...@@ -167,9 +168,10 @@ static int test_bitmaps(struct btrfs_block_group_cache *cache)
} }
/* This is the high grade jackassery */ /* This is the high grade jackassery */
static int test_bitmaps_and_extents(struct btrfs_block_group_cache *cache) static int test_bitmaps_and_extents(struct btrfs_block_group_cache *cache,
u32 sectorsize)
{ {
u64 bitmap_offset = (u64)(BITS_PER_BITMAP * 4096); u64 bitmap_offset = (u64)(BITS_PER_BITMAP * sectorsize);
int ret; int ret;
test_msg("Running bitmap and extent tests\n"); test_msg("Running bitmap and extent tests\n");
...@@ -401,7 +403,8 @@ static int check_cache_empty(struct btrfs_block_group_cache *cache) ...@@ -401,7 +403,8 @@ static int check_cache_empty(struct btrfs_block_group_cache *cache)
* requests. * requests.
*/ */
static int static int
test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache,
u32 sectorsize)
{ {
int ret; int ret;
u64 offset; u64 offset;
...@@ -539,7 +542,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -539,7 +542,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
* The goal is to test that the bitmap entry space stealing doesn't * The goal is to test that the bitmap entry space stealing doesn't
* steal this space region. * steal this space region.
*/ */
ret = btrfs_add_free_space(cache, SZ_128M + SZ_16M, 4096); ret = btrfs_add_free_space(cache, SZ_128M + SZ_16M, sectorsize);
if (ret) { if (ret) {
test_msg("Error adding free space: %d\n", ret); test_msg("Error adding free space: %d\n", ret);
return ret; return ret;
...@@ -597,8 +600,8 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -597,8 +600,8 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
return -ENOENT; return -ENOENT;
} }
if (cache->free_space_ctl->free_space != (SZ_1M + 4096)) { if (cache->free_space_ctl->free_space != (SZ_1M + sectorsize)) {
test_msg("Cache free space is not 1Mb + 4Kb\n"); test_msg("Cache free space is not 1Mb + %u\n", sectorsize);
return -EINVAL; return -EINVAL;
} }
...@@ -611,22 +614,25 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -611,22 +614,25 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
return -EINVAL; return -EINVAL;
} }
/* All that remains is a 4Kb free space region in a bitmap. Confirm. */ /*
* All that remains is a sectorsize free space region in a bitmap.
* Confirm.
*/
ret = check_num_extents_and_bitmaps(cache, 1, 1); ret = check_num_extents_and_bitmaps(cache, 1, 1);
if (ret) if (ret)
return ret; return ret;
if (cache->free_space_ctl->free_space != 4096) { if (cache->free_space_ctl->free_space != sectorsize) {
test_msg("Cache free space is not 4Kb\n"); test_msg("Cache free space is not %u\n", sectorsize);
return -EINVAL; return -EINVAL;
} }
offset = btrfs_find_space_for_alloc(cache, offset = btrfs_find_space_for_alloc(cache,
0, 4096, 0, 0, sectorsize, 0,
&max_extent_size); &max_extent_size);
if (offset != (SZ_128M + SZ_16M)) { if (offset != (SZ_128M + SZ_16M)) {
test_msg("Failed to allocate 4Kb from space cache, returned offset is: %llu\n", test_msg("Failed to allocate %u, returned offset : %llu\n",
offset); sectorsize, offset);
return -EINVAL; return -EINVAL;
} }
...@@ -733,7 +739,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -733,7 +739,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
* The goal is to test that the bitmap entry space stealing doesn't * The goal is to test that the bitmap entry space stealing doesn't
* steal this space region. * steal this space region.
*/ */
ret = btrfs_add_free_space(cache, SZ_32M, 8192); ret = btrfs_add_free_space(cache, SZ_32M, 2 * sectorsize);
if (ret) { if (ret) {
test_msg("Error adding free space: %d\n", ret); test_msg("Error adding free space: %d\n", ret);
return ret; return ret;
...@@ -757,7 +763,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -757,7 +763,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
/* /*
* Confirm that our extent entry didn't stole all free space from the * Confirm that our extent entry didn't stole all free space from the
* bitmap, because of the small 8Kb free space region. * bitmap, because of the small 2 * sectorsize free space region.
*/ */
ret = check_num_extents_and_bitmaps(cache, 2, 1); ret = check_num_extents_and_bitmaps(cache, 2, 1);
if (ret) if (ret)
...@@ -783,8 +789,8 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -783,8 +789,8 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
return -ENOENT; return -ENOENT;
} }
if (cache->free_space_ctl->free_space != (SZ_1M + 8192)) { if (cache->free_space_ctl->free_space != (SZ_1M + 2 * sectorsize)) {
test_msg("Cache free space is not 1Mb + 8Kb\n"); test_msg("Cache free space is not 1Mb + %u\n", 2 * sectorsize);
return -EINVAL; return -EINVAL;
} }
...@@ -796,21 +802,25 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -796,21 +802,25 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
return -EINVAL; return -EINVAL;
} }
/* All that remains is a 8Kb free space region in a bitmap. Confirm. */ /*
* All that remains is 2 * sectorsize free space region
* in a bitmap. Confirm.
*/
ret = check_num_extents_and_bitmaps(cache, 1, 1); ret = check_num_extents_and_bitmaps(cache, 1, 1);
if (ret) if (ret)
return ret; return ret;
if (cache->free_space_ctl->free_space != 8192) { if (cache->free_space_ctl->free_space != 2 * sectorsize) {
test_msg("Cache free space is not 8Kb\n"); test_msg("Cache free space is not %u\n", 2 * sectorsize);
return -EINVAL; return -EINVAL;
} }
offset = btrfs_find_space_for_alloc(cache, offset = btrfs_find_space_for_alloc(cache,
0, 8192, 0, 0, 2 * sectorsize, 0,
&max_extent_size); &max_extent_size);
if (offset != SZ_32M) { if (offset != SZ_32M) {
test_msg("Failed to allocate 8Kb from space cache, returned offset is: %llu\n", test_msg("Failed to allocate %u, offset: %llu\n",
2 * sectorsize,
offset); offset);
return -EINVAL; return -EINVAL;
} }
...@@ -825,7 +835,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache) ...@@ -825,7 +835,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache)
return 0; return 0;
} }
int btrfs_test_free_space_cache(void) int btrfs_test_free_space_cache(u32 sectorsize, u32 nodesize)
{ {
struct btrfs_block_group_cache *cache; struct btrfs_block_group_cache *cache;
struct btrfs_root *root = NULL; struct btrfs_root *root = NULL;
...@@ -833,13 +843,19 @@ int btrfs_test_free_space_cache(void) ...@@ -833,13 +843,19 @@ int btrfs_test_free_space_cache(void)
test_msg("Running btrfs free space cache tests\n"); test_msg("Running btrfs free space cache tests\n");
cache = btrfs_alloc_dummy_block_group(1024 * 1024 * 1024); /*
* For ppc64 (with 64k page size), bytes per bitmap might be
* larger than 1G. To make bitmap test available in ppc64,
* alloc dummy block group whose size cross bitmaps.
*/
cache = btrfs_alloc_dummy_block_group(BITS_PER_BITMAP * sectorsize
+ PAGE_SIZE, sectorsize);
if (!cache) { if (!cache) {
test_msg("Couldn't run the tests\n"); test_msg("Couldn't run the tests\n");
return 0; return 0;
} }
root = btrfs_alloc_dummy_root(); root = btrfs_alloc_dummy_root(sectorsize, nodesize);
if (IS_ERR(root)) { if (IS_ERR(root)) {
ret = PTR_ERR(root); ret = PTR_ERR(root);
goto out; goto out;
...@@ -855,14 +871,14 @@ int btrfs_test_free_space_cache(void) ...@@ -855,14 +871,14 @@ int btrfs_test_free_space_cache(void)
ret = test_extents(cache); ret = test_extents(cache);
if (ret) if (ret)
goto out; goto out;
ret = test_bitmaps(cache); ret = test_bitmaps(cache, sectorsize);
if (ret) if (ret)
goto out; goto out;
ret = test_bitmaps_and_extents(cache); ret = test_bitmaps_and_extents(cache, sectorsize);
if (ret) if (ret)
goto out; goto out;
ret = test_steal_space_from_bitmap_to_extent(cache); ret = test_steal_space_from_bitmap_to_extent(cache, sectorsize);
out: out:
btrfs_free_dummy_block_group(cache); btrfs_free_dummy_block_group(cache);
btrfs_free_dummy_root(root); btrfs_free_dummy_root(root);
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
* Boston, MA 021110-1307, USA. * Boston, MA 021110-1307, USA.
*/ */
#include <linux/types.h>
#include "btrfs-tests.h" #include "btrfs-tests.h"
#include "../ctree.h" #include "../ctree.h"
#include "../disk-io.h" #include "../disk-io.h"
...@@ -30,7 +31,7 @@ struct free_space_extent { ...@@ -30,7 +31,7 @@ struct free_space_extent {
* The test cases align their operations to this in order to hit some of the * The test cases align their operations to this in order to hit some of the
* edge cases in the bitmap code. * edge cases in the bitmap code.
*/ */
#define BITMAP_RANGE (BTRFS_FREE_SPACE_BITMAP_BITS * 4096) #define BITMAP_RANGE (BTRFS_FREE_SPACE_BITMAP_BITS * PAGE_SIZE)
static int __check_free_space_extents(struct btrfs_trans_handle *trans, static int __check_free_space_extents(struct btrfs_trans_handle *trans,
struct btrfs_fs_info *fs_info, struct btrfs_fs_info *fs_info,
...@@ -439,7 +440,8 @@ typedef int (*test_func_t)(struct btrfs_trans_handle *, ...@@ -439,7 +440,8 @@ typedef int (*test_func_t)(struct btrfs_trans_handle *,
struct btrfs_block_group_cache *, struct btrfs_block_group_cache *,
struct btrfs_path *); struct btrfs_path *);
static int run_test(test_func_t test_func, int bitmaps) static int run_test(test_func_t test_func, int bitmaps,
u32 sectorsize, u32 nodesize)
{ {
struct btrfs_root *root = NULL; struct btrfs_root *root = NULL;
struct btrfs_block_group_cache *cache = NULL; struct btrfs_block_group_cache *cache = NULL;
...@@ -447,7 +449,7 @@ static int run_test(test_func_t test_func, int bitmaps) ...@@ -447,7 +449,7 @@ static int run_test(test_func_t test_func, int bitmaps)
struct btrfs_path *path = NULL; struct btrfs_path *path = NULL;
int ret; int ret;
root = btrfs_alloc_dummy_root(); root = btrfs_alloc_dummy_root(sectorsize, nodesize);
if (IS_ERR(root)) { if (IS_ERR(root)) {
test_msg("Couldn't allocate dummy root\n"); test_msg("Couldn't allocate dummy root\n");
ret = PTR_ERR(root); ret = PTR_ERR(root);
...@@ -466,7 +468,8 @@ static int run_test(test_func_t test_func, int bitmaps) ...@@ -466,7 +468,8 @@ static int run_test(test_func_t test_func, int bitmaps)
root->fs_info->free_space_root = root; root->fs_info->free_space_root = root;
root->fs_info->tree_root = root; root->fs_info->tree_root = root;
root->node = alloc_test_extent_buffer(root->fs_info, 4096); root->node = alloc_test_extent_buffer(root->fs_info,
nodesize, nodesize);
if (!root->node) { if (!root->node) {
test_msg("Couldn't allocate dummy buffer\n"); test_msg("Couldn't allocate dummy buffer\n");
ret = -ENOMEM; ret = -ENOMEM;
...@@ -474,9 +477,9 @@ static int run_test(test_func_t test_func, int bitmaps) ...@@ -474,9 +477,9 @@ static int run_test(test_func_t test_func, int bitmaps)
} }
btrfs_set_header_level(root->node, 0); btrfs_set_header_level(root->node, 0);
btrfs_set_header_nritems(root->node, 0); btrfs_set_header_nritems(root->node, 0);
root->alloc_bytenr += 8192; root->alloc_bytenr += 2 * nodesize;
cache = btrfs_alloc_dummy_block_group(8 * BITMAP_RANGE); cache = btrfs_alloc_dummy_block_group(8 * BITMAP_RANGE, sectorsize);
if (!cache) { if (!cache) {
test_msg("Couldn't allocate dummy block group cache\n"); test_msg("Couldn't allocate dummy block group cache\n");
ret = -ENOMEM; ret = -ENOMEM;
...@@ -534,17 +537,18 @@ static int run_test(test_func_t test_func, int bitmaps) ...@@ -534,17 +537,18 @@ static int run_test(test_func_t test_func, int bitmaps)
return ret; return ret;
} }
static int run_test_both_formats(test_func_t test_func) static int run_test_both_formats(test_func_t test_func,
u32 sectorsize, u32 nodesize)
{ {
int ret; int ret;
ret = run_test(test_func, 0); ret = run_test(test_func, 0, sectorsize, nodesize);
if (ret) if (ret)
return ret; return ret;
return run_test(test_func, 1); return run_test(test_func, 1, sectorsize, nodesize);
} }
int btrfs_test_free_space_tree(void) int btrfs_test_free_space_tree(u32 sectorsize, u32 nodesize)
{ {
test_func_t tests[] = { test_func_t tests[] = {
test_empty_block_group, test_empty_block_group,
...@@ -561,9 +565,11 @@ int btrfs_test_free_space_tree(void) ...@@ -561,9 +565,11 @@ int btrfs_test_free_space_tree(void)
test_msg("Running free space tree tests\n"); test_msg("Running free space tree tests\n");
for (i = 0; i < ARRAY_SIZE(tests); i++) { for (i = 0; i < ARRAY_SIZE(tests); i++) {
int ret = run_test_both_formats(tests[i]); int ret = run_test_both_formats(tests[i], sectorsize,
nodesize);
if (ret) { if (ret) {
test_msg("%pf failed\n", tests[i]); test_msg("%pf : sectorsize %u failed\n",
tests[i], sectorsize);
return ret; return ret;
} }
} }
......
This diff is collapsed.
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment