Commit 4d502572 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Greg Kroah-Hartman

netlink: Don't shift with UB on nlk->ngroups

[ Upstream commit 61f4b237 ]

On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting in
hang during boot.
Check for 0 ngroups and use (unsigned long long) as a type to shift.

Fixes: 7acf9d42 ("netlink: Do not subscribe to non-existent groups").
Reported-by: default avatarkernel test robot <rong.a.chen@intel.com>
Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4f08437d
...@@ -985,7 +985,11 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr, ...@@ -985,7 +985,11 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
if (err) if (err)
return err; return err;
} }
groups &= (1UL << nlk->ngroups) - 1;
if (nlk->ngroups == 0)
groups = 0;
else
groups &= (1ULL << nlk->ngroups) - 1;
bound = nlk->bound; bound = nlk->bound;
if (bound) { if (bound) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment