Commit 4d8a453b authored by Christoph Hellwig's avatar Christoph Hellwig

[PATCH] get rid of TRUE/FALSE abuse in the scsi midlayer

Kernel codingsyle explicitly forbids it.  Fortunately there aren't many
useres left.
parent 1f3e6f50
...@@ -172,8 +172,7 @@ void scsi_times_out(Scsi_Cmnd *scmd) ...@@ -172,8 +172,7 @@ void scsi_times_out(Scsi_Cmnd *scmd)
* see whether the host or the device is offline. * see whether the host or the device is offline.
* *
* Return value: * Return value:
* FALSE when dev was taken offline by error recovery. TRUE OK to * 0 when dev was taken offline by error recovery. 1 OK to proceed.
* proceed.
**/ **/
int scsi_block_when_processing_errors(Scsi_Device *sdev) int scsi_block_when_processing_errors(Scsi_Device *sdev)
{ {
...@@ -1157,7 +1156,7 @@ static void scsi_eh_offline_sdevs(Scsi_Cmnd *sc_todo, struct Scsi_Host *shost) ...@@ -1157,7 +1156,7 @@ static void scsi_eh_offline_sdevs(Scsi_Cmnd *sc_todo, struct Scsi_Host *shost)
if (scsi_eh_eflags_chk(scmd, SCSI_EH_CMD_TIMEOUT)) if (scsi_eh_eflags_chk(scmd, SCSI_EH_CMD_TIMEOUT))
scmd->result |= (DRIVER_TIMEOUT << 24); scmd->result |= (DRIVER_TIMEOUT << 24);
scmd->device->online = FALSE; scmd->device->online = 0;
scsi_eh_finish_cmd(scmd, shost); scsi_eh_finish_cmd(scmd, shost);
} }
return; return;
...@@ -1222,7 +1221,7 @@ int scsi_decide_disposition(Scsi_Cmnd *scmd) ...@@ -1222,7 +1221,7 @@ int scsi_decide_disposition(Scsi_Cmnd *scmd)
* if the device is offline, then we clearly just pass the result back * if the device is offline, then we clearly just pass the result back
* up to the top level. * up to the top level.
*/ */
if (scmd->device->online == FALSE) { if (!scmd->device->online) {
SCSI_LOG_ERROR_RECOVERY(5, printk("%s: device offline - report" SCSI_LOG_ERROR_RECOVERY(5, printk("%s: device offline - report"
" as SUCCESS\n", " as SUCCESS\n",
__FUNCTION__)); __FUNCTION__));
......
...@@ -1060,7 +1060,7 @@ void scsi_request_fn(request_queue_t * q) ...@@ -1060,7 +1060,7 @@ void scsi_request_fn(request_queue_t * q)
*/ */
void scsi_block_requests(struct Scsi_Host * SHpnt) void scsi_block_requests(struct Scsi_Host * SHpnt)
{ {
SHpnt->host_self_blocked = TRUE; SHpnt->host_self_blocked = 1;
} }
/* /*
...@@ -1087,7 +1087,7 @@ void scsi_unblock_requests(struct Scsi_Host * SHpnt) ...@@ -1087,7 +1087,7 @@ void scsi_unblock_requests(struct Scsi_Host * SHpnt)
{ {
Scsi_Device *SDloop; Scsi_Device *SDloop;
SHpnt->host_self_blocked = FALSE; SHpnt->host_self_blocked = 0;
/* Now that we are unblocked, try to start the queues. */ /* Now that we are unblocked, try to start the queues. */
list_for_each_entry(SDloop, &SHpnt->my_devices, siblings) list_for_each_entry(SDloop, &SHpnt->my_devices, siblings)
scsi_queue_next_request(SDloop->request_queue, NULL); scsi_queue_next_request(SDloop->request_queue, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment