Commit 4ef174a3 authored by Yang Yingliang's avatar Yang Yingliang Committed by Martin K. Petersen

scsi: hpsa: Fix error handling in hpsa_add_sas_host()

hpsa_sas_port_add_phy() does:
  ...
  sas_phy_add()  -> may return error here
  sas_port_add_phy()
  ...

Whereas hpsa_free_sas_phy() does:
  ...
  sas_port_delete_phy()
  sas_phy_delete()
  ...

If hpsa_sas_port_add_phy() returns an error, hpsa_free_sas_phy() can not be
called to free the memory because the port and the phy have not been added
yet.

Replace hpsa_free_sas_phy() with sas_phy_free() and kfree() to avoid kernel
crash in this case.

Fixes: d04e62b9 ("hpsa: add in sas transport class")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221110151129.394389-1-yangyingliang@huawei.comSigned-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 78316e9d
...@@ -9786,7 +9786,8 @@ static int hpsa_add_sas_host(struct ctlr_info *h) ...@@ -9786,7 +9786,8 @@ static int hpsa_add_sas_host(struct ctlr_info *h)
return 0; return 0;
free_sas_phy: free_sas_phy:
hpsa_free_sas_phy(hpsa_sas_phy); sas_phy_free(hpsa_sas_phy->phy);
kfree(hpsa_sas_phy);
free_sas_port: free_sas_port:
hpsa_free_sas_port(hpsa_sas_port); hpsa_free_sas_port(hpsa_sas_port);
free_sas_node: free_sas_node:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment