Commit 4f7f4409 authored by Frederic Weisbecker's avatar Frederic Weisbecker Committed by Thomas Gleixner

tick/nohz: Don't shutdown the lowres tick from itself

In lowres dynticks mode, just like in highres dynticks mode, when there
is no tick to program in the future, the tick eventually gets
deactivated either:

  * From the idle loop if in idle mode.
  * From the IRQ exit if in full dynticks mode.

Therefore there is no need to deactivate it from the tick itself. This
just just brings more overhead in the idle tick path for no reason.
Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
Link: https://lore.kernel.org/r/20230912104406.312185-4-frederic@kernel.org
parent 822deeed
...@@ -1403,18 +1403,16 @@ static void tick_nohz_lowres_handler(struct clock_event_device *dev) ...@@ -1403,18 +1403,16 @@ static void tick_nohz_lowres_handler(struct clock_event_device *dev)
tick_sched_do_timer(ts, now); tick_sched_do_timer(ts, now);
tick_sched_handle(ts, regs); tick_sched_handle(ts, regs);
if (unlikely(ts->tick_stopped)) {
/* /*
* The clockevent device is not reprogrammed, so change the * In dynticks mode, tick reprogram is deferred:
* clock event device to ONESHOT_STOPPED to avoid spurious * - to the idle task if in dynticks-idle
* interrupts on devices which might not be truly one shot. * - to IRQ exit if in full-dynticks.
*/ */
tick_program_event(KTIME_MAX, 1); if (likely(!ts->tick_stopped)) {
return;
}
hrtimer_forward(&ts->sched_timer, now, TICK_NSEC); hrtimer_forward(&ts->sched_timer, now, TICK_NSEC);
tick_program_event(hrtimer_get_expires(&ts->sched_timer), 1); tick_program_event(hrtimer_get_expires(&ts->sched_timer), 1);
}
} }
static inline void tick_nohz_activate(struct tick_sched *ts, int mode) static inline void tick_nohz_activate(struct tick_sched *ts, int mode)
...@@ -1519,7 +1517,11 @@ static enum hrtimer_restart tick_nohz_highres_handler(struct hrtimer *timer) ...@@ -1519,7 +1517,11 @@ static enum hrtimer_restart tick_nohz_highres_handler(struct hrtimer *timer)
else else
ts->next_tick = 0; ts->next_tick = 0;
/* No need to reprogram if we are in idle or full dynticks mode */ /*
* In dynticks mode, tick reprogram is deferred:
* - to the idle task if in dynticks-idle
* - to IRQ exit if in full-dynticks.
*/
if (unlikely(ts->tick_stopped)) if (unlikely(ts->tick_stopped))
return HRTIMER_NORESTART; return HRTIMER_NORESTART;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment