Commit 50483c32 authored by Linus Torvalds's avatar Linus Torvalds

Merge git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile

Pull arch/tile (really asm-generic) update from Chris Metcalf:
 "These are a couple of asm-generic changes that apply to tile."

* git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile:
  compat: use sys_sendfile64() implementation for sendfile syscall
  [PATCH v3] ipc: provide generic compat versions of IPC syscalls
parents 7fda0412 1631fcea
...@@ -213,4 +213,7 @@ config HAVE_CMPXCHG_LOCAL ...@@ -213,4 +213,7 @@ config HAVE_CMPXCHG_LOCAL
config HAVE_CMPXCHG_DOUBLE config HAVE_CMPXCHG_DOUBLE
bool bool
config ARCH_WANT_OLD_COMPAT_IPC
bool
source "kernel/gcov/Kconfig" source "kernel/gcov/Kconfig"
...@@ -2457,6 +2457,7 @@ config MIPS32_COMPAT ...@@ -2457,6 +2457,7 @@ config MIPS32_COMPAT
config COMPAT config COMPAT
bool bool
depends on MIPS32_COMPAT depends on MIPS32_COMPAT
select ARCH_WANT_OLD_COMPAT_IPC
default y default y
config SYSVIPC_COMPAT config SYSVIPC_COMPAT
......
...@@ -154,6 +154,7 @@ config COMPAT ...@@ -154,6 +154,7 @@ config COMPAT
bool bool
default y if PPC64 default y if PPC64
select COMPAT_BINFMT_ELF select COMPAT_BINFMT_ELF
select ARCH_WANT_OLD_COMPAT_IPC
config SYSVIPC_COMPAT config SYSVIPC_COMPAT
bool bool
......
...@@ -219,6 +219,7 @@ config COMPAT ...@@ -219,6 +219,7 @@ config COMPAT
prompt "Kernel support for 31 bit emulation" prompt "Kernel support for 31 bit emulation"
depends on 64BIT depends on 64BIT
select COMPAT_BINFMT_ELF select COMPAT_BINFMT_ELF
select ARCH_WANT_OLD_COMPAT_IPC
help help
Select this option if you want to enable your system kernel to Select this option if you want to enable your system kernel to
handle system-calls from ELF binaries for 31 bit ESA. This option handle system-calls from ELF binaries for 31 bit ESA. This option
......
...@@ -577,6 +577,7 @@ config COMPAT ...@@ -577,6 +577,7 @@ config COMPAT
depends on SPARC64 depends on SPARC64
default y default y
select COMPAT_BINFMT_ELF select COMPAT_BINFMT_ELF
select ARCH_WANT_OLD_COMPAT_IPC
config SYSVIPC_COMPAT config SYSVIPC_COMPAT
bool bool
......
...@@ -242,17 +242,6 @@ long compat_sys_fallocate(int fd, int mode, ...@@ -242,17 +242,6 @@ long compat_sys_fallocate(int fd, int mode,
long compat_sys_sched_rr_get_interval(compat_pid_t pid, long compat_sys_sched_rr_get_interval(compat_pid_t pid,
struct compat_timespec __user *interval); struct compat_timespec __user *interval);
/* Versions of compat functions that differ from generic Linux. */
struct compat_msgbuf;
long tile_compat_sys_msgsnd(int msqid,
struct compat_msgbuf __user *msgp,
size_t msgsz, int msgflg);
long tile_compat_sys_msgrcv(int msqid,
struct compat_msgbuf __user *msgp,
size_t msgsz, long msgtyp, int msgflg);
long tile_compat_sys_ptrace(compat_long_t request, compat_long_t pid,
compat_long_t addr, compat_long_t data);
/* Tilera Linux syscalls that don't have "compat" versions. */ /* Tilera Linux syscalls that don't have "compat" versions. */
#define compat_sys_flush_cache sys_flush_cache #define compat_sys_flush_cache sys_flush_cache
......
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#define __SYSCALL_COMPAT #define __SYSCALL_COMPAT
#include <linux/compat.h> #include <linux/compat.h>
#include <linux/msg.h>
#include <linux/syscalls.h> #include <linux/syscalls.h>
#include <linux/kdev_t.h> #include <linux/kdev_t.h>
#include <linux/fs.h> #include <linux/fs.h>
...@@ -95,52 +94,10 @@ long compat_sys_sched_rr_get_interval(compat_pid_t pid, ...@@ -95,52 +94,10 @@ long compat_sys_sched_rr_get_interval(compat_pid_t pid,
return ret; return ret;
} }
/*
* The usual compat_sys_msgsnd() and _msgrcv() seem to be assuming
* some different calling convention than our normal 32-bit tile code.
*/
/* Already defined in ipc/compat.c, but we need it here. */
struct compat_msgbuf {
compat_long_t mtype;
char mtext[1];
};
long tile_compat_sys_msgsnd(int msqid,
struct compat_msgbuf __user *msgp,
size_t msgsz, int msgflg)
{
compat_long_t mtype;
if (get_user(mtype, &msgp->mtype))
return -EFAULT;
return do_msgsnd(msqid, mtype, msgp->mtext, msgsz, msgflg);
}
long tile_compat_sys_msgrcv(int msqid,
struct compat_msgbuf __user *msgp,
size_t msgsz, long msgtyp, int msgflg)
{
long err, mtype;
err = do_msgrcv(msqid, &mtype, msgp->mtext, msgsz, msgtyp, msgflg);
if (err < 0)
goto out;
if (put_user(mtype, &msgp->mtype))
err = -EFAULT;
out:
return err;
}
/* Provide the compat syscall number to call mapping. */ /* Provide the compat syscall number to call mapping. */
#undef __SYSCALL #undef __SYSCALL
#define __SYSCALL(nr, call) [nr] = (call), #define __SYSCALL(nr, call) [nr] = (call),
/* The generic versions of these don't work for Tile. */
#define compat_sys_msgrcv tile_compat_sys_msgrcv
#define compat_sys_msgsnd tile_compat_sys_msgsnd
/* See comments in sys.c */ /* See comments in sys.c */
#define compat_sys_fadvise64_64 sys32_fadvise64_64 #define compat_sys_fadvise64_64 sys32_fadvise64_64
#define compat_sys_readahead sys32_readahead #define compat_sys_readahead sys32_readahead
......
...@@ -2177,6 +2177,7 @@ config IA32_AOUT ...@@ -2177,6 +2177,7 @@ config IA32_AOUT
config COMPAT config COMPAT
def_bool y def_bool y
depends on IA32_EMULATION depends on IA32_EMULATION
select ARCH_WANT_OLD_COMPAT_IPC
config COMPAT_FOR_U64_ALIGNMENT config COMPAT_FOR_U64_ALIGNMENT
def_bool COMPAT def_bool COMPAT
......
...@@ -218,7 +218,7 @@ __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev) ...@@ -218,7 +218,7 @@ __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev)
/* fs/sendfile.c */ /* fs/sendfile.c */
#define __NR3264_sendfile 71 #define __NR3264_sendfile 71
__SC_3264(__NR3264_sendfile, sys_sendfile64, sys_sendfile) __SYSCALL(__NR3264_sendfile, sys_sendfile64)
/* fs/select.c */ /* fs/select.c */
#define __NR_pselect6 72 #define __NR_pselect6 72
......
...@@ -224,6 +224,7 @@ struct compat_sysinfo; ...@@ -224,6 +224,7 @@ struct compat_sysinfo;
struct compat_sysctl_args; struct compat_sysctl_args;
struct compat_kexec_segment; struct compat_kexec_segment;
struct compat_mq_attr; struct compat_mq_attr;
struct compat_msgbuf;
extern void compat_exit_robust_list(struct task_struct *curr); extern void compat_exit_robust_list(struct task_struct *curr);
...@@ -234,13 +235,22 @@ asmlinkage long ...@@ -234,13 +235,22 @@ asmlinkage long
compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr, compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
compat_size_t __user *len_ptr); compat_size_t __user *len_ptr);
#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
long compat_sys_semctl(int first, int second, int third, void __user *uptr); long compat_sys_semctl(int first, int second, int third, void __user *uptr);
long compat_sys_msgsnd(int first, int second, int third, void __user *uptr); long compat_sys_msgsnd(int first, int second, int third, void __user *uptr);
long compat_sys_msgrcv(int first, int second, int msgtyp, int third, long compat_sys_msgrcv(int first, int second, int msgtyp, int third,
int version, void __user *uptr); int version, void __user *uptr);
long compat_sys_msgctl(int first, int second, void __user *uptr);
long compat_sys_shmat(int first, int second, compat_uptr_t third, int version, long compat_sys_shmat(int first, int second, compat_uptr_t third, int version,
void __user *uptr); void __user *uptr);
#else
long compat_sys_semctl(int semid, int semnum, int cmd, int arg);
long compat_sys_msgsnd(int msqid, struct compat_msgbuf __user *msgp,
size_t msgsz, int msgflg);
long compat_sys_msgrcv(int msqid, struct compat_msgbuf __user *msgp,
size_t msgsz, long msgtyp, int msgflg);
long compat_sys_shmat(int shmid, compat_uptr_t shmaddr, int shmflg);
#endif
long compat_sys_msgctl(int first, int second, void __user *uptr);
long compat_sys_shmctl(int first, int second, void __user *uptr); long compat_sys_shmctl(int first, int second, void __user *uptr);
long compat_sys_semtimedop(int semid, struct sembuf __user *tsems, long compat_sys_semtimedop(int semid, struct sembuf __user *tsems,
unsigned nsems, const struct compat_timespec __user *timeout); unsigned nsems, const struct compat_timespec __user *timeout);
......
...@@ -27,6 +27,7 @@ ...@@ -27,6 +27,7 @@
#include <linux/msg.h> #include <linux/msg.h>
#include <linux/shm.h> #include <linux/shm.h>
#include <linux/syscalls.h> #include <linux/syscalls.h>
#include <linux/ptrace.h>
#include <linux/mutex.h> #include <linux/mutex.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
...@@ -117,6 +118,7 @@ extern int sem_ctls[]; ...@@ -117,6 +118,7 @@ extern int sem_ctls[];
static inline int compat_ipc_parse_version(int *cmd) static inline int compat_ipc_parse_version(int *cmd)
{ {
#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
int version = *cmd & IPC_64; int version = *cmd & IPC_64;
/* this is tricky: architectures that have support for the old /* this is tricky: architectures that have support for the old
...@@ -128,6 +130,10 @@ static inline int compat_ipc_parse_version(int *cmd) ...@@ -128,6 +130,10 @@ static inline int compat_ipc_parse_version(int *cmd)
*cmd &= ~IPC_64; *cmd &= ~IPC_64;
#endif #endif
return version; return version;
#else
/* With the asm-generic APIs, we always use the 64-bit versions. */
return IPC_64;
#endif
} }
static inline int __get_compat_ipc64_perm(struct ipc64_perm *p64, static inline int __get_compat_ipc64_perm(struct ipc64_perm *p64,
...@@ -232,10 +238,9 @@ static inline int put_compat_semid_ds(struct semid64_ds *s, ...@@ -232,10 +238,9 @@ static inline int put_compat_semid_ds(struct semid64_ds *s,
return err; return err;
} }
long compat_sys_semctl(int first, int second, int third, void __user *uptr) static long do_compat_semctl(int first, int second, int third, u32 pad)
{ {
union semun fourth; union semun fourth;
u32 pad;
int err, err2; int err, err2;
struct semid64_ds s64; struct semid64_ds s64;
struct semid64_ds __user *up64; struct semid64_ds __user *up64;
...@@ -243,10 +248,6 @@ long compat_sys_semctl(int first, int second, int third, void __user *uptr) ...@@ -243,10 +248,6 @@ long compat_sys_semctl(int first, int second, int third, void __user *uptr)
memset(&s64, 0, sizeof(s64)); memset(&s64, 0, sizeof(s64));
if (!uptr)
return -EINVAL;
if (get_user(pad, (u32 __user *) uptr))
return -EFAULT;
if ((third & (~IPC_64)) == SETVAL) if ((third & (~IPC_64)) == SETVAL)
fourth.val = (int) pad; fourth.val = (int) pad;
else else
...@@ -305,6 +306,18 @@ long compat_sys_semctl(int first, int second, int third, void __user *uptr) ...@@ -305,6 +306,18 @@ long compat_sys_semctl(int first, int second, int third, void __user *uptr)
return err; return err;
} }
#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
long compat_sys_semctl(int first, int second, int third, void __user *uptr)
{
u32 pad;
if (!uptr)
return -EINVAL;
if (get_user(pad, (u32 __user *) uptr))
return -EFAULT;
return do_compat_semctl(first, second, third, pad);
}
long compat_sys_msgsnd(int first, int second, int third, void __user *uptr) long compat_sys_msgsnd(int first, int second, int third, void __user *uptr)
{ {
struct compat_msgbuf __user *up = uptr; struct compat_msgbuf __user *up = uptr;
...@@ -353,6 +366,37 @@ long compat_sys_msgrcv(int first, int second, int msgtyp, int third, ...@@ -353,6 +366,37 @@ long compat_sys_msgrcv(int first, int second, int msgtyp, int third,
out: out:
return err; return err;
} }
#else
long compat_sys_semctl(int semid, int semnum, int cmd, int arg)
{
return do_compat_semctl(semid, semnum, cmd, arg);
}
long compat_sys_msgsnd(int msqid, struct compat_msgbuf __user *msgp,
size_t msgsz, int msgflg)
{
compat_long_t mtype;
if (get_user(mtype, &msgp->mtype))
return -EFAULT;
return do_msgsnd(msqid, mtype, msgp->mtext, msgsz, msgflg);
}
long compat_sys_msgrcv(int msqid, struct compat_msgbuf __user *msgp,
size_t msgsz, long msgtyp, int msgflg)
{
long err, mtype;
err = do_msgrcv(msqid, &mtype, msgp->mtext, msgsz, msgtyp, msgflg);
if (err < 0)
goto out;
if (put_user(mtype, &msgp->mtype))
err = -EFAULT;
out:
return err;
}
#endif
static inline int get_compat_msqid64(struct msqid64_ds *m64, static inline int get_compat_msqid64(struct msqid64_ds *m64,
struct compat_msqid64_ds __user *up64) struct compat_msqid64_ds __user *up64)
...@@ -470,6 +514,7 @@ long compat_sys_msgctl(int first, int second, void __user *uptr) ...@@ -470,6 +514,7 @@ long compat_sys_msgctl(int first, int second, void __user *uptr)
return err; return err;
} }
#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
long compat_sys_shmat(int first, int second, compat_uptr_t third, int version, long compat_sys_shmat(int first, int second, compat_uptr_t third, int version,
void __user *uptr) void __user *uptr)
{ {
...@@ -485,6 +530,19 @@ long compat_sys_shmat(int first, int second, compat_uptr_t third, int version, ...@@ -485,6 +530,19 @@ long compat_sys_shmat(int first, int second, compat_uptr_t third, int version,
uaddr = compat_ptr(third); uaddr = compat_ptr(third);
return put_user(raddr, uaddr); return put_user(raddr, uaddr);
} }
#else
long compat_sys_shmat(int shmid, compat_uptr_t shmaddr, int shmflg)
{
unsigned long ret;
long err;
err = do_shmat(shmid, compat_ptr(shmaddr), shmflg, &ret);
if (err)
return err;
force_successful_syscall_return();
return (long)ret;
}
#endif
static inline int get_compat_shmid64_ds(struct shmid64_ds *s64, static inline int get_compat_shmid64_ds(struct shmid64_ds *s64,
struct compat_shmid64_ds __user *up64) struct compat_shmid64_ds __user *up64)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment