selftests: android: ion: return Kselftest Skip code for skipped tests

When ion test is skipped because of unmet dependencies and/or unsupported
configuration, it returns 0 which is treated as a pass by the Kselftest
framework. This leads to false positive result even when the test could
not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Kselftest framework SKIP code is 4 and the framework prints appropriate
messages to indicate that the test is skipped.
Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
Acked-by: default avatarPintu Agarwal <pintu.ping@gmail.com>
Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
parent 4ed8b153
...@@ -4,6 +4,9 @@ heapsize=4096 ...@@ -4,6 +4,9 @@ heapsize=4096
TCID="ion_test.sh" TCID="ion_test.sh"
errcode=0 errcode=0
# Kselftest framework requirement - SKIP code is 4.
ksft_skip=4
run_test() run_test()
{ {
heaptype=$1 heaptype=$1
...@@ -25,7 +28,7 @@ check_root() ...@@ -25,7 +28,7 @@ check_root()
uid=$(id -u) uid=$(id -u)
if [ $uid -ne 0 ]; then if [ $uid -ne 0 ]; then
echo $TCID: must be run as root >&2 echo $TCID: must be run as root >&2
exit 0 exit $ksft_skip
fi fi
} }
...@@ -35,7 +38,7 @@ check_device() ...@@ -35,7 +38,7 @@ check_device()
if [ ! -e $DEVICE ]; then if [ ! -e $DEVICE ]; then
echo $TCID: No $DEVICE device found >&2 echo $TCID: No $DEVICE device found >&2
echo $TCID: May be CONFIG_ION is not set >&2 echo $TCID: May be CONFIG_ION is not set >&2
exit 0 exit $ksft_skip
fi fi
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment