Commit 52e220d3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Al Viro

VFS: collect_mounts() should return an ERR_PTR

This should actually be returning an ERR_PTR on error instead of NULL.
That was how it was designed and all the callers expect it.

[AV: actually, that's what "VFS: Make clone_mnt()/copy_tree()/collect_mounts()
return errors" missed - originally collect_mounts() was expected to return
NULL on failure]

Cc: <stable@vger.kernel.org> # 3.10+
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 821ff77c
...@@ -1429,7 +1429,7 @@ struct vfsmount *collect_mounts(struct path *path) ...@@ -1429,7 +1429,7 @@ struct vfsmount *collect_mounts(struct path *path)
CL_COPY_ALL | CL_PRIVATE); CL_COPY_ALL | CL_PRIVATE);
namespace_unlock(); namespace_unlock();
if (IS_ERR(tree)) if (IS_ERR(tree))
return NULL; return ERR_CAST(tree);
return &tree->mnt; return &tree->mnt;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment