Commit 5366778b authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

USB: legousbtower: fix memleak on disconnect

commit b6c03e5f upstream.

If disconnect() races with release() after a process has been
interrupted, release() could end up returning early and the driver would
fail to free its driver data.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 99b45e7a
...@@ -419,10 +419,7 @@ static int tower_release (struct inode *inode, struct file *file) ...@@ -419,10 +419,7 @@ static int tower_release (struct inode *inode, struct file *file)
goto exit; goto exit;
} }
if (mutex_lock_interruptible(&dev->lock)) { mutex_lock(&dev->lock);
retval = -ERESTARTSYS;
goto exit;
}
if (dev->open_count != 1) { if (dev->open_count != 1) {
dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n", dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment