Commit 542694df authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown

ASoC: soc-core: rename soc_post_component_init() to soc_rtd_init()

It is easy to read code if it is cleanly using paired function/naming,
like start <-> stop, register <-> unregister, etc, etc.
But, current ALSA SoC code is very random, unbalance, not paired, etc.
It is easy to create bug at the such code, and it will be difficult to
debug.

From function name point of view, "soc_post_component_init()" sounds
like "component initialize function".
But in reality it is rtd setup function.

This patch renames soc_post_component_init() to soc_rtd_init()
Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87v9uo7lc3.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 495efdb0
...@@ -1340,13 +1340,12 @@ static int soc_probe_component(struct snd_soc_card *card, ...@@ -1340,13 +1340,12 @@ static int soc_probe_component(struct snd_soc_card *card,
return ret; return ret;
} }
static void rtd_release(struct device *dev) static void soc_rtd_release(struct device *dev)
{ {
kfree(dev); kfree(dev);
} }
static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd, static int soc_rtd_init(struct snd_soc_pcm_runtime *rtd, const char *name)
const char *name)
{ {
int ret = 0; int ret = 0;
...@@ -1355,7 +1354,7 @@ static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd, ...@@ -1355,7 +1354,7 @@ static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd,
if (!rtd->dev) if (!rtd->dev)
return -ENOMEM; return -ENOMEM;
rtd->dev->parent = rtd->card->dev; rtd->dev->parent = rtd->card->dev;
rtd->dev->release = rtd_release; rtd->dev->release = soc_rtd_release;
rtd->dev->groups = soc_dev_attr_groups; rtd->dev->groups = soc_dev_attr_groups;
dev_set_name(rtd->dev, "%s", name); dev_set_name(rtd->dev, "%s", name);
dev_set_drvdata(rtd->dev, rtd); dev_set_drvdata(rtd->dev, rtd);
...@@ -1483,7 +1482,7 @@ static int soc_probe_link_dais(struct snd_soc_card *card, ...@@ -1483,7 +1482,7 @@ static int soc_probe_link_dais(struct snd_soc_card *card,
return ret; return ret;
} }
ret = soc_post_component_init(rtd, dai_link->name); ret = soc_rtd_init(rtd, dai_link->name);
if (ret) if (ret)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment