Commit 591940e2 authored by Steve Wilkins's avatar Steve Wilkins Committed by Conor Dooley

firmware: microchip: fix incorrect error report of programming:timeout on success

After successfully programming the SPI flash with an MFPS auto update
image, the error sysfs attribute reports programming:timeout.
This is caused by an incorrect check on the return value from
wait_for_completion_timeout() in mpfs_auto_update_poll_complete().

Fixes: ec5b0f11 ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: default avatarSteve Wilkins <steve.wilkins@raymarine.com>
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
parent 8400291e
...@@ -166,7 +166,7 @@ static enum fw_upload_err mpfs_auto_update_poll_complete(struct fw_upload *fw_up ...@@ -166,7 +166,7 @@ static enum fw_upload_err mpfs_auto_update_poll_complete(struct fw_upload *fw_up
*/ */
ret = wait_for_completion_timeout(&priv->programming_complete, ret = wait_for_completion_timeout(&priv->programming_complete,
msecs_to_jiffies(AUTO_UPDATE_TIMEOUT_MS)); msecs_to_jiffies(AUTO_UPDATE_TIMEOUT_MS));
if (ret) if (!ret)
return FW_UPLOAD_ERR_TIMEOUT; return FW_UPLOAD_ERR_TIMEOUT;
return FW_UPLOAD_ERR_NONE; return FW_UPLOAD_ERR_NONE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment