Commit 59b4cc43 authored by Zhang Shurong's avatar Zhang Shurong Committed by Kalle Valo

wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()

If there is a failure during kstrtobool_from_user()
rtw89_debug_priv_btc_manual_set should return a negative error code
instead of returning the count directly.

Fix this bug by returning an error code instead of a count after
a failed call of the function "kstrtobool_from_user". Moreover
I omitted the label "out" with this source code correction.

Fixes: e3ec7017 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: default avatarZhang Shurong <zhang_shurong@foxmail.com>
Acked-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/tencent_1C09B99BD7DA9CAD18B00C8F0F050F540607@qq.com
parent 8986f0a9
...@@ -3193,12 +3193,14 @@ static ssize_t rtw89_debug_priv_btc_manual_set(struct file *filp, ...@@ -3193,12 +3193,14 @@ static ssize_t rtw89_debug_priv_btc_manual_set(struct file *filp,
struct rtw89_dev *rtwdev = debugfs_priv->rtwdev; struct rtw89_dev *rtwdev = debugfs_priv->rtwdev;
struct rtw89_btc *btc = &rtwdev->btc; struct rtw89_btc *btc = &rtwdev->btc;
bool btc_manual; bool btc_manual;
int ret;
if (kstrtobool_from_user(user_buf, count, &btc_manual)) ret = kstrtobool_from_user(user_buf, count, &btc_manual);
goto out; if (ret)
return ret;
btc->ctrl.manual = btc_manual; btc->ctrl.manual = btc_manual;
out:
return count; return count;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment