Commit 5bbe6049 authored by Peng Li's avatar Peng Li Committed by Marc Kleine-Budde

net: at91_can: fix the comments style issue

Networking block comments don't use an empty /* line,
use /* Comment...

Block comments use * on subsequent lines.
Block comments use a trailing */ on a separate line.

This patch fixes the comments style issues.

Link: https://lore.kernel.org/r/1624096589-13452-9-git-send-email-huangguangbin2@huawei.comSigned-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent fc1d97d4
...@@ -317,8 +317,7 @@ static void at91_setup_mailboxes(struct net_device *dev) ...@@ -317,8 +317,7 @@ static void at91_setup_mailboxes(struct net_device *dev)
unsigned int i; unsigned int i;
u32 reg_mid; u32 reg_mid;
/* /* Due to a chip bug (errata 50.2.6.3 & 50.3.5.3) the first
* Due to a chip bug (errata 50.2.6.3 & 50.3.5.3) the first
* mailbox is disabled. The next 11 mailboxes are used as a * mailbox is disabled. The next 11 mailboxes are used as a
* reception FIFO. The last mailbox is configured with * reception FIFO. The last mailbox is configured with
* overwrite option. The overwrite flag indicates a FIFO * overwrite option. The overwrite flag indicates a FIFO
...@@ -424,8 +423,7 @@ static void at91_chip_stop(struct net_device *dev, enum can_state state) ...@@ -424,8 +423,7 @@ static void at91_chip_stop(struct net_device *dev, enum can_state state)
priv->can.state = state; priv->can.state = state;
} }
/* /* theory of operation:
* theory of operation:
* *
* According to the datasheet priority 0 is the highest priority, 15 * According to the datasheet priority 0 is the highest priority, 15
* is the lowest. If two mailboxes have the same priority level the * is the lowest. If two mailboxes have the same priority level the
...@@ -487,8 +485,7 @@ static netdev_tx_t at91_start_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -487,8 +485,7 @@ static netdev_tx_t at91_start_xmit(struct sk_buff *skb, struct net_device *dev)
/* _NOTE_: subtract AT91_MB_TX_FIRST offset from mb! */ /* _NOTE_: subtract AT91_MB_TX_FIRST offset from mb! */
can_put_echo_skb(skb, dev, mb - get_mb_tx_first(priv), 0); can_put_echo_skb(skb, dev, mb - get_mb_tx_first(priv), 0);
/* /* we have to stop the queue and deliver all messages in case
* we have to stop the queue and deliver all messages in case
* of a prio+mb counter wrap around. This is the case if * of a prio+mb counter wrap around. This is the case if
* tx_next buffer prio and mailbox equals 0. * tx_next buffer prio and mailbox equals 0.
* *
...@@ -799,8 +796,7 @@ static int at91_poll(struct napi_struct *napi, int quota) ...@@ -799,8 +796,7 @@ static int at91_poll(struct napi_struct *napi, int quota)
if (reg_sr & get_irq_mb_rx(priv)) if (reg_sr & get_irq_mb_rx(priv))
work_done += at91_poll_rx(dev, quota - work_done); work_done += at91_poll_rx(dev, quota - work_done);
/* /* The error bits are clear on read,
* The error bits are clear on read,
* so use saved value from irq handler. * so use saved value from irq handler.
*/ */
reg_sr |= priv->reg_sr; reg_sr |= priv->reg_sr;
...@@ -820,8 +816,7 @@ static int at91_poll(struct napi_struct *napi, int quota) ...@@ -820,8 +816,7 @@ static int at91_poll(struct napi_struct *napi, int quota)
return work_done; return work_done;
} }
/* /* theory of operation:
* theory of operation:
* *
* priv->tx_echo holds the number of the oldest can_frame put for * priv->tx_echo holds the number of the oldest can_frame put for
* transmission into the hardware, but not yet ACKed by the CAN tx * transmission into the hardware, but not yet ACKed by the CAN tx
...@@ -850,8 +845,7 @@ static void at91_irq_tx(struct net_device *dev, u32 reg_sr) ...@@ -850,8 +845,7 @@ static void at91_irq_tx(struct net_device *dev, u32 reg_sr)
/* Disable irq for this TX mailbox */ /* Disable irq for this TX mailbox */
at91_write(priv, AT91_IDR, 1 << mb); at91_write(priv, AT91_IDR, 1 << mb);
/* /* only echo if mailbox signals us a transfer
* only echo if mailbox signals us a transfer
* complete (MSR_MRDY). Otherwise it's a tansfer * complete (MSR_MRDY). Otherwise it's a tansfer
* abort. "can_bus_off()" takes care about the skbs * abort. "can_bus_off()" takes care about the skbs
* parked in the echo queue. * parked in the echo queue.
...@@ -866,8 +860,7 @@ static void at91_irq_tx(struct net_device *dev, u32 reg_sr) ...@@ -866,8 +860,7 @@ static void at91_irq_tx(struct net_device *dev, u32 reg_sr)
} }
} }
/* /* restart queue if we don't have a wrap around but restart if
* restart queue if we don't have a wrap around but restart if
* we get a TX int for the last can frame directly before a * we get a TX int for the last can frame directly before a
* wrap around. * wrap around.
*/ */
...@@ -887,8 +880,7 @@ static void at91_irq_err_state(struct net_device *dev, ...@@ -887,8 +880,7 @@ static void at91_irq_err_state(struct net_device *dev,
switch (priv->can.state) { switch (priv->can.state) {
case CAN_STATE_ERROR_ACTIVE: case CAN_STATE_ERROR_ACTIVE:
/* /* from: ERROR_ACTIVE
* from: ERROR_ACTIVE
* to : ERROR_WARNING, ERROR_PASSIVE, BUS_OFF * to : ERROR_WARNING, ERROR_PASSIVE, BUS_OFF
* => : there was a warning int * => : there was a warning int
*/ */
...@@ -904,8 +896,7 @@ static void at91_irq_err_state(struct net_device *dev, ...@@ -904,8 +896,7 @@ static void at91_irq_err_state(struct net_device *dev,
} }
fallthrough; fallthrough;
case CAN_STATE_ERROR_WARNING: case CAN_STATE_ERROR_WARNING:
/* /* from: ERROR_ACTIVE, ERROR_WARNING
* from: ERROR_ACTIVE, ERROR_WARNING
* to : ERROR_PASSIVE, BUS_OFF * to : ERROR_PASSIVE, BUS_OFF
* => : error passive int * => : error passive int
*/ */
...@@ -921,8 +912,7 @@ static void at91_irq_err_state(struct net_device *dev, ...@@ -921,8 +912,7 @@ static void at91_irq_err_state(struct net_device *dev,
} }
break; break;
case CAN_STATE_BUS_OFF: case CAN_STATE_BUS_OFF:
/* /* from: BUS_OFF
* from: BUS_OFF
* to : ERROR_ACTIVE, ERROR_WARNING, ERROR_PASSIVE * to : ERROR_ACTIVE, ERROR_WARNING, ERROR_PASSIVE
*/ */
if (new_state <= CAN_STATE_ERROR_PASSIVE) { if (new_state <= CAN_STATE_ERROR_PASSIVE) {
...@@ -942,8 +932,7 @@ static void at91_irq_err_state(struct net_device *dev, ...@@ -942,8 +932,7 @@ static void at91_irq_err_state(struct net_device *dev,
/* process state changes depending on the new state */ /* process state changes depending on the new state */
switch (new_state) { switch (new_state) {
case CAN_STATE_ERROR_ACTIVE: case CAN_STATE_ERROR_ACTIVE:
/* /* actually we want to enable AT91_IRQ_WARN here, but
* actually we want to enable AT91_IRQ_WARN here, but
* it screws up the system under certain * it screws up the system under certain
* circumstances. so just enable AT91_IRQ_ERRP, thus * circumstances. so just enable AT91_IRQ_ERRP, thus
* the "fallthrough" * the "fallthrough"
...@@ -1055,8 +1044,7 @@ static void at91_irq_err(struct net_device *dev) ...@@ -1055,8 +1044,7 @@ static void at91_irq_err(struct net_device *dev)
priv->can.state = new_state; priv->can.state = new_state;
} }
/* /* interrupt handler
* interrupt handler
*/ */
static irqreturn_t at91_irq(int irq, void *dev_id) static irqreturn_t at91_irq(int irq, void *dev_id)
{ {
...@@ -1077,8 +1065,7 @@ static irqreturn_t at91_irq(int irq, void *dev_id) ...@@ -1077,8 +1065,7 @@ static irqreturn_t at91_irq(int irq, void *dev_id)
/* Receive or error interrupt? -> napi */ /* Receive or error interrupt? -> napi */
if (reg_sr & (get_irq_mb_rx(priv) | AT91_IRQ_ERR_FRAME)) { if (reg_sr & (get_irq_mb_rx(priv) | AT91_IRQ_ERR_FRAME)) {
/* /* The error bits are clear on read,
* The error bits are clear on read,
* save for later use. * save for later use.
*/ */
priv->reg_sr = reg_sr; priv->reg_sr = reg_sr;
...@@ -1135,8 +1122,7 @@ static int at91_open(struct net_device *dev) ...@@ -1135,8 +1122,7 @@ static int at91_open(struct net_device *dev)
return err; return err;
} }
/* /* stop CAN bus activity
* stop CAN bus activity
*/ */
static int at91_close(struct net_device *dev) static int at91_close(struct net_device *dev)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment