Commit 5bf1f439 authored by Denis Efremov's avatar Denis Efremov Committed by Ben Myers

xfs:xfs_dir2_node.c: pointer use before check for null

ASSERT on args takes place after args dereference.
This assertion is redundant since we are going to panic anyway.

Found by Linux Driver Verification project (linuxtesting.org) -
PVS-Studio analyzer.
Signed-off-by: default avatarDenis Efremov <yefremov.denis@gmail.com>
Reviewed-by: default avatarBen Myers <bpm@sgi.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent ad22c7a0
...@@ -1327,7 +1327,6 @@ xfs_dir2_leafn_split( ...@@ -1327,7 +1327,6 @@ xfs_dir2_leafn_split(
args = state->args; args = state->args;
dp = args->dp; dp = args->dp;
mp = dp->i_mount; mp = dp->i_mount;
ASSERT(args != NULL);
ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC); ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC);
error = xfs_da_grow_inode(args, &blkno); error = xfs_da_grow_inode(args, &blkno);
if (error) { if (error) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment