Commit 5c5d6796 authored by Randy Dunlap's avatar Randy Dunlap Committed by Jakub Kicinski

net/tipc: fix name_table.c kernel-doc

Fix name_table.c kernel-doc warnings in preparation for adding to the
networking docbook.

../net/tipc/name_table.c:115: warning: Function parameter or member 'start' not described in 'service_range_foreach_match'
../net/tipc/name_table.c:115: warning: Function parameter or member 'end' not described in 'service_range_foreach_match'
../net/tipc/name_table.c:127: warning: Function parameter or member 'start' not described in 'service_range_match_first'
../net/tipc/name_table.c:127: warning: Function parameter or member 'end' not described in 'service_range_match_first'
../net/tipc/name_table.c:176: warning: Function parameter or member 'start' not described in 'service_range_match_next'
../net/tipc/name_table.c:176: warning: Function parameter or member 'end' not described in 'service_range_match_next'
../net/tipc/name_table.c:225: warning: Function parameter or member 'type' not described in 'tipc_publ_create'
../net/tipc/name_table.c:225: warning: Function parameter or member 'lower' not described in 'tipc_publ_create'
../net/tipc/name_table.c:225: warning: Function parameter or member 'upper' not described in 'tipc_publ_create'
../net/tipc/name_table.c:225: warning: Function parameter or member 'scope' not described in 'tipc_publ_create'
../net/tipc/name_table.c:225: warning: Function parameter or member 'node' not described in 'tipc_publ_create'
../net/tipc/name_table.c:225: warning: Function parameter or member 'port' not described in 'tipc_publ_create'
../net/tipc/name_table.c:225: warning: Function parameter or member 'key' not described in 'tipc_publ_create'
../net/tipc/name_table.c:252: warning: Function parameter or member 'type' not described in 'tipc_service_create'
../net/tipc/name_table.c:252: warning: Function parameter or member 'hd' not described in 'tipc_service_create'
../net/tipc/name_table.c:367: warning: Function parameter or member 'sr' not described in 'tipc_service_remove_publ'
../net/tipc/name_table.c:367: warning: Function parameter or member 'node' not described in 'tipc_service_remove_publ'
../net/tipc/name_table.c:367: warning: Function parameter or member 'key' not described in 'tipc_service_remove_publ'
../net/tipc/name_table.c:383: warning: Function parameter or member 'pa' not described in 'publication_after'
../net/tipc/name_table.c:383: warning: Function parameter or member 'pb' not described in 'publication_after'
../net/tipc/name_table.c:401: warning: Function parameter or member 'service' not described in 'tipc_service_subscribe'
../net/tipc/name_table.c:401: warning: Function parameter or member 'sub' not described in 'tipc_service_subscribe'
../net/tipc/name_table.c:546: warning: Function parameter or member 'net' not described in 'tipc_nametbl_translate'
../net/tipc/name_table.c:546: warning: Function parameter or member 'type' not described in 'tipc_nametbl_translate'
../net/tipc/name_table.c:546: warning: Function parameter or member 'instance' not described in 'tipc_nametbl_translate'
../net/tipc/name_table.c:546: warning: Function parameter or member 'dnode' not described in 'tipc_nametbl_translate'
../net/tipc/name_table.c:762: warning: Function parameter or member 'net' not described in 'tipc_nametbl_withdraw'
../net/tipc/name_table.c:762: warning: Function parameter or member 'type' not described in 'tipc_nametbl_withdraw'
../net/tipc/name_table.c:762: warning: Function parameter or member 'lower' not described in 'tipc_nametbl_withdraw'
../net/tipc/name_table.c:762: warning: Function parameter or member 'upper' not described in 'tipc_nametbl_withdraw'
../net/tipc/name_table.c:762: warning: Function parameter or member 'key' not described in 'tipc_nametbl_withdraw'
../net/tipc/name_table.c:796: warning: Function parameter or member 'sub' not described in 'tipc_nametbl_subscribe'
../net/tipc/name_table.c:826: warning: Function parameter or member 'sub' not described in 'tipc_nametbl_unsubscribe'
../net/tipc/name_table.c:876: warning: Function parameter or member 'net' not described in 'tipc_service_delete'
../net/tipc/name_table.c:876: warning: Function parameter or member 'sc' not described in 'tipc_service_delete'
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cb67296e
...@@ -104,7 +104,8 @@ RB_DECLARE_CALLBACKS_MAX(static, sr_callbacks, ...@@ -104,7 +104,8 @@ RB_DECLARE_CALLBACKS_MAX(static, sr_callbacks,
* range match * range match
* @sr: the service range pointer as a loop cursor * @sr: the service range pointer as a loop cursor
* @sc: the pointer to tipc service which holds the service range rbtree * @sc: the pointer to tipc service which holds the service range rbtree
* @start, end: the range (end >= start) for matching * @start: beginning of the search range (end >= start) for matching
* @end: end of the search range (end >= start) for matching
*/ */
#define service_range_foreach_match(sr, sc, start, end) \ #define service_range_foreach_match(sr, sc, start, end) \
for (sr = service_range_match_first((sc)->ranges.rb_node, \ for (sr = service_range_match_first((sc)->ranges.rb_node, \
...@@ -118,7 +119,8 @@ RB_DECLARE_CALLBACKS_MAX(static, sr_callbacks, ...@@ -118,7 +119,8 @@ RB_DECLARE_CALLBACKS_MAX(static, sr_callbacks,
/** /**
* service_range_match_first - find first service range matching a range * service_range_match_first - find first service range matching a range
* @n: the root node of service range rbtree for searching * @n: the root node of service range rbtree for searching
* @start, end: the range (end >= start) for matching * @start: beginning of the search range (end >= start) for matching
* @end: end of the search range (end >= start) for matching
* *
* Return: the leftmost service range node in the rbtree that overlaps the * Return: the leftmost service range node in the rbtree that overlaps the
* specific range if any. Otherwise, returns NULL. * specific range if any. Otherwise, returns NULL.
...@@ -167,7 +169,8 @@ static struct service_range *service_range_match_first(struct rb_node *n, ...@@ -167,7 +169,8 @@ static struct service_range *service_range_match_first(struct rb_node *n,
/** /**
* service_range_match_next - find next service range matching a range * service_range_match_next - find next service range matching a range
* @n: a node in service range rbtree from which the searching starts * @n: a node in service range rbtree from which the searching starts
* @start, end: the range (end >= start) for matching * @start: beginning of the search range (end >= start) for matching
* @end: end of the search range (end >= start) for matching
* *
* Return: the next service range node to the given node in the rbtree that * Return: the next service range node to the given node in the rbtree that
* overlaps the specific range if any. Otherwise, returns NULL. * overlaps the specific range if any. Otherwise, returns NULL.
...@@ -219,6 +222,13 @@ static int hash(int x) ...@@ -219,6 +222,13 @@ static int hash(int x)
/** /**
* tipc_publ_create - create a publication structure * tipc_publ_create - create a publication structure
* @type: name sequence type
* @lower: name sequence lower bound
* @upper: name sequence upper bound
* @scope: publication scope
* @node: network address of publishing socket
* @port: publishing port
* @key: publication key
*/ */
static struct publication *tipc_publ_create(u32 type, u32 lower, u32 upper, static struct publication *tipc_publ_create(u32 type, u32 lower, u32 upper,
u32 scope, u32 node, u32 port, u32 scope, u32 node, u32 port,
...@@ -246,6 +256,8 @@ static struct publication *tipc_publ_create(u32 type, u32 lower, u32 upper, ...@@ -246,6 +256,8 @@ static struct publication *tipc_publ_create(u32 type, u32 lower, u32 upper,
/** /**
* tipc_service_create - create a service structure for the specified 'type' * tipc_service_create - create a service structure for the specified 'type'
* @type: service type
* @hd: name_table services list
* *
* Allocates a single range structure and sets it to all 0's. * Allocates a single range structure and sets it to all 0's.
*/ */
...@@ -362,6 +374,9 @@ static struct publication *tipc_service_insert_publ(struct net *net, ...@@ -362,6 +374,9 @@ static struct publication *tipc_service_insert_publ(struct net *net,
/** /**
* tipc_service_remove_publ - remove a publication from a service * tipc_service_remove_publ - remove a publication from a service
* @sr: service_range to remove publication from
* @node: target node
* @key: target publication key
*/ */
static struct publication *tipc_service_remove_publ(struct service_range *sr, static struct publication *tipc_service_remove_publ(struct service_range *sr,
u32 node, u32 key) u32 node, u32 key)
...@@ -378,7 +393,7 @@ static struct publication *tipc_service_remove_publ(struct service_range *sr, ...@@ -378,7 +393,7 @@ static struct publication *tipc_service_remove_publ(struct service_range *sr,
return NULL; return NULL;
} }
/** /*
* Code reused: time_after32() for the same purpose * Code reused: time_after32() for the same purpose
*/ */
#define publication_after(pa, pb) time_after32((pa)->id, (pb)->id) #define publication_after(pa, pb) time_after32((pa)->id, (pb)->id)
...@@ -396,6 +411,8 @@ static int tipc_publ_sort(void *priv, struct list_head *a, ...@@ -396,6 +411,8 @@ static int tipc_publ_sort(void *priv, struct list_head *a,
* tipc_service_subscribe - attach a subscription, and optionally * tipc_service_subscribe - attach a subscription, and optionally
* issue the prescribed number of events if there is any service * issue the prescribed number of events if there is any service
* range overlapping with the requested range * range overlapping with the requested range
* @service: the tipc_service to attach the @sub to
* @sub: the subscription to attach
*/ */
static void tipc_service_subscribe(struct tipc_service *service, static void tipc_service_subscribe(struct tipc_service *service,
struct tipc_subscription *sub) struct tipc_subscription *sub)
...@@ -529,8 +546,10 @@ struct publication *tipc_nametbl_remove_publ(struct net *net, u32 type, ...@@ -529,8 +546,10 @@ struct publication *tipc_nametbl_remove_publ(struct net *net, u32 type,
/** /**
* tipc_nametbl_translate - perform service instance to socket translation * tipc_nametbl_translate - perform service instance to socket translation
* * @net: network namespace
* On entry, 'dnode' is the search domain used during translation. * @type: message type
* @instance: message instance
* @dnode: the search domain used during translation
* *
* On exit: * On exit:
* - if translation is deferred to another node, leave 'dnode' unchanged and * - if translation is deferred to another node, leave 'dnode' unchanged and
...@@ -757,6 +776,11 @@ struct publication *tipc_nametbl_publish(struct net *net, u32 type, u32 lower, ...@@ -757,6 +776,11 @@ struct publication *tipc_nametbl_publish(struct net *net, u32 type, u32 lower,
/** /**
* tipc_nametbl_withdraw - withdraw a service binding * tipc_nametbl_withdraw - withdraw a service binding
* @net: network namespace
* @type: service type
* @lower: service range lower bound
* @upper: service range upper bound
* @key: target publication key
*/ */
int tipc_nametbl_withdraw(struct net *net, u32 type, u32 lower, int tipc_nametbl_withdraw(struct net *net, u32 type, u32 lower,
u32 upper, u32 key) u32 upper, u32 key)
...@@ -792,6 +816,7 @@ int tipc_nametbl_withdraw(struct net *net, u32 type, u32 lower, ...@@ -792,6 +816,7 @@ int tipc_nametbl_withdraw(struct net *net, u32 type, u32 lower,
/** /**
* tipc_nametbl_subscribe - add a subscription object to the name table * tipc_nametbl_subscribe - add a subscription object to the name table
* @sub: subscription to add
*/ */
bool tipc_nametbl_subscribe(struct tipc_subscription *sub) bool tipc_nametbl_subscribe(struct tipc_subscription *sub)
{ {
...@@ -822,6 +847,7 @@ bool tipc_nametbl_subscribe(struct tipc_subscription *sub) ...@@ -822,6 +847,7 @@ bool tipc_nametbl_subscribe(struct tipc_subscription *sub)
/** /**
* tipc_nametbl_unsubscribe - remove a subscription object from name table * tipc_nametbl_unsubscribe - remove a subscription object from name table
* @sub: subscription to remove
*/ */
void tipc_nametbl_unsubscribe(struct tipc_subscription *sub) void tipc_nametbl_unsubscribe(struct tipc_subscription *sub)
{ {
...@@ -872,6 +898,8 @@ int tipc_nametbl_init(struct net *net) ...@@ -872,6 +898,8 @@ int tipc_nametbl_init(struct net *net)
/** /**
* tipc_service_delete - purge all publications for a service and delete it * tipc_service_delete - purge all publications for a service and delete it
* @net: the associated network namespace
* @sc: tipc_service to delete
*/ */
static void tipc_service_delete(struct net *net, struct tipc_service *sc) static void tipc_service_delete(struct net *net, struct tipc_service *sc)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment