Commit 5f48d4d9 authored by Baokun Li's avatar Baokun Li Committed by Theodore Ts'o

ext4: save unnecessary indentation in ext4_ext_create_new_leaf()

Save an indentation level in ext4_ext_create_new_leaf() by removing
unnecessary 'else'. Besides, the variable 'ee_block' is declared to
avoid line breaks. No functional changes.
Suggested-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240822023545.1994557-26-libaokun@huaweicloud.comSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 2352e3e4
...@@ -1403,6 +1403,7 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode, ...@@ -1403,6 +1403,7 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode,
{ {
struct ext4_ext_path *curp; struct ext4_ext_path *curp;
int depth, i, err = 0; int depth, i, err = 0;
ext4_lblk_t ee_block = le32_to_cpu(newext->ee_block);
repeat: repeat:
i = depth = ext_depth(inode); i = depth = ext_depth(inode);
...@@ -1424,20 +1425,17 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode, ...@@ -1424,20 +1425,17 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode,
goto errout; goto errout;
/* refill path */ /* refill path */
path = ext4_find_extent(inode, path = ext4_find_extent(inode, ee_block, path, gb_flags);
(ext4_lblk_t)le32_to_cpu(newext->ee_block),
path, gb_flags);
return path; return path;
} else { }
/* tree is full, time to grow in depth */ /* tree is full, time to grow in depth */
err = ext4_ext_grow_indepth(handle, inode, mb_flags); err = ext4_ext_grow_indepth(handle, inode, mb_flags);
if (err) if (err)
goto errout; goto errout;
/* refill path */ /* refill path */
path = ext4_find_extent(inode, path = ext4_find_extent(inode, ee_block, path, gb_flags);
(ext4_lblk_t)le32_to_cpu(newext->ee_block),
path, gb_flags);
if (IS_ERR(path)) if (IS_ERR(path))
return path; return path;
...@@ -1450,7 +1448,7 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode, ...@@ -1450,7 +1448,7 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode,
/* now we need to split */ /* now we need to split */
goto repeat; goto repeat;
} }
}
return path; return path;
errout: errout:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment