Commit 5f71a3ef authored by Thomas Kavanagh's avatar Thomas Kavanagh Committed by Wolfram Sang

i2c: algo: pca: Fix mode selection for PCA9665

The code currently always selects turbo mode for PCA9665, no matter which
clock frequency is configured. This is because it compares the clock frequency
against constants reflecting (boundary / 100). Compare against real boundary
frequencies to fix the problem.
Signed-off-by: default avatarThomas Kavanagh <tkavanagh@juniper.net>
Signed-off-by: default avatarGuenter Roeck <groeck@juniper.net>
Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
parent 4a5b2b26
...@@ -476,17 +476,17 @@ static int pca_init(struct i2c_adapter *adap) ...@@ -476,17 +476,17 @@ static int pca_init(struct i2c_adapter *adap)
/* To avoid integer overflow, use clock/100 for calculations */ /* To avoid integer overflow, use clock/100 for calculations */
clock = pca_clock(pca_data) / 100; clock = pca_clock(pca_data) / 100;
if (pca_data->i2c_clock > 10000) { if (pca_data->i2c_clock > 1000000) {
mode = I2C_PCA_MODE_TURBO; mode = I2C_PCA_MODE_TURBO;
min_tlow = 14; min_tlow = 14;
min_thi = 5; min_thi = 5;
raise_fall_time = 22; /* Raise 11e-8s, Fall 11e-8s */ raise_fall_time = 22; /* Raise 11e-8s, Fall 11e-8s */
} else if (pca_data->i2c_clock > 4000) { } else if (pca_data->i2c_clock > 400000) {
mode = I2C_PCA_MODE_FASTP; mode = I2C_PCA_MODE_FASTP;
min_tlow = 17; min_tlow = 17;
min_thi = 9; min_thi = 9;
raise_fall_time = 22; /* Raise 11e-8s, Fall 11e-8s */ raise_fall_time = 22; /* Raise 11e-8s, Fall 11e-8s */
} else if (pca_data->i2c_clock > 1000) { } else if (pca_data->i2c_clock > 100000) {
mode = I2C_PCA_MODE_FAST; mode = I2C_PCA_MODE_FAST;
min_tlow = 44; min_tlow = 44;
min_thi = 20; min_thi = 20;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment