Commit 6224abda authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by David S. Miller

net: core: drop pointless check in __dev_alloc_name

The only caller passes a stack buffer as buf, so it won't equal the
passed-in name. Moreover, we're already using buf as a scratch buffer
inside the if (p) {} block, so if buf and name were the same, that
snprintf() call would be overwriting its own format string.
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c46d7642
...@@ -1095,7 +1095,6 @@ static int __dev_alloc_name(struct net *net, const char *name, char *buf) ...@@ -1095,7 +1095,6 @@ static int __dev_alloc_name(struct net *net, const char *name, char *buf)
free_page((unsigned long) inuse); free_page((unsigned long) inuse);
} }
if (buf != name)
snprintf(buf, IFNAMSIZ, name, i); snprintf(buf, IFNAMSIZ, name, i);
if (!__dev_get_by_name(net, buf)) if (!__dev_get_by_name(net, buf))
return i; return i;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment