Commit 62adf167 authored by Frederic Barrat's avatar Frederic Barrat Committed by Kamal Mostafa

cxl: Make vPHB device node match adapter's

BugLink: http://bugs.launchpad.net/bugs/1594847

On bare-metal, when a device is attached to the cxl card, lsvpd shows
a location code such as (with cxlflash):
     # lsvpd -l sg22
     ...
     *YL U78CB.001.WZS0073-P1-C33-B0-T0-L0
which makes it hard to easily identify the cxl adapter owning the
flash device, since in this example C33 refers to a P8 processor.

lsvpd looks in the parent devices until it finds a location code, so the
device node for the vPHB ends up being used.

By reusing the device node of the adapter for the vPHB, lsvpd shows:
     # lsvpd -l sg16
     ...
     *YL U78C9.001.WZS09XA-P1-C7-B1-T0-L3
where C7 is the PCI slot of the cxl adapter.

On powerVM, the vPHB was already using the adapter device node, so
there's no change there.

Tested by cxlflash on bare-metal and powerVM.
Signed-off-by: default avatarFrederic Barrat <fbarrat@linux.vnet.ibm.com>
Reviewed-by: default avatarMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Acked-by: default avatarIan Munsie <imunsie@au1.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
(cherry picked from linux-next commit a4307390)
Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
Acked-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 55828f28
...@@ -208,20 +208,19 @@ static struct pci_controller_ops cxl_pci_controller_ops = ...@@ -208,20 +208,19 @@ static struct pci_controller_ops cxl_pci_controller_ops =
int cxl_pci_vphb_add(struct cxl_afu *afu) int cxl_pci_vphb_add(struct cxl_afu *afu)
{ {
struct pci_dev *phys_dev; struct pci_controller *phb;
struct pci_controller *phb, *phys_phb;
struct device_node *vphb_dn; struct device_node *vphb_dn;
struct device *parent; struct device *parent;
if (cpu_has_feature(CPU_FTR_HVMODE)) { /* The parent device is the adapter. Reuse the device node of
phys_dev = to_pci_dev(afu->adapter->dev.parent); * the adapter.
phys_phb = pci_bus_to_host(phys_dev->bus); * We don't seem to care what device node is used for the vPHB,
vphb_dn = phys_phb->dn; * but tools such as lsvpd walk up the device parents looking
parent = &phys_dev->dev; * for a valid location code, so we might as well show devices
} else { * attached to the adapter as being located on that adapter.
vphb_dn = afu->adapter->dev.parent->of_node; */
parent = afu->adapter->dev.parent; parent = afu->adapter->dev.parent;
} vphb_dn = parent->of_node;
/* Alloc and setup PHB data structure */ /* Alloc and setup PHB data structure */
phb = pcibios_alloc_controller(vphb_dn); phb = pcibios_alloc_controller(vphb_dn);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment