Commit 644f6bf7 authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher

gfs2: gfs2_ail_empty_gl no log flush on error

Before this patch, function gfs2_ail_empty_gl called gfs2_log_flush even
in cases where it encountered an error. It should probably skip the log
flush and leave the file system in an inconsistent state, letting a
subsequent withdraw force the journal to be replayed to reestablish
metadata consistency.
Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent b97e583c
...@@ -132,6 +132,7 @@ static int gfs2_ail_empty_gl(struct gfs2_glock *gl) ...@@ -132,6 +132,7 @@ static int gfs2_ail_empty_gl(struct gfs2_glock *gl)
gfs2_trans_end(sdp); gfs2_trans_end(sdp);
flush: flush:
if (!ret)
gfs2_log_flush(sdp, NULL, GFS2_LOG_HEAD_FLUSH_NORMAL | gfs2_log_flush(sdp, NULL, GFS2_LOG_HEAD_FLUSH_NORMAL |
GFS2_LFC_AIL_EMPTY_GL); GFS2_LFC_AIL_EMPTY_GL);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment