Commit 64ac0bef authored by Jiaxun Yang's avatar Jiaxun Yang Committed by Thomas Bogendoerfer

MIPS: jump_label: Fix compat branch range check

Cast upper bound of branch range to long to do signed compare,
avoid negative offset trigger this warning.

Fixes: 9b6584e3 ("MIPS: jump_label: Use compact branches for >= r6")
Signed-off-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 2a296157
...@@ -56,7 +56,7 @@ void arch_jump_label_transform(struct jump_entry *e, ...@@ -56,7 +56,7 @@ void arch_jump_label_transform(struct jump_entry *e,
* The branch offset must fit in the instruction's 26 * The branch offset must fit in the instruction's 26
* bit field. * bit field.
*/ */
WARN_ON((offset >= BIT(25)) || WARN_ON((offset >= (long)BIT(25)) ||
(offset < -(long)BIT(25))); (offset < -(long)BIT(25)));
insn.j_format.opcode = bc6_op; insn.j_format.opcode = bc6_op;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment