Commit 68000a0d authored by Thara Gopinath's avatar Thara Gopinath Committed by Zhang Rui

thermal: Fix locking in cooling device sysfs update cur_state

Sysfs interface to update cooling device cur_state does not
currently holding cooling device lock sometimes leading to
stale values in cur_state if getting updated simultanelously
from user space and thermal framework. Adding the proper locking
code fixes this issue.
Signed-off-by: default avatarThara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
parent 964f4843
...@@ -712,11 +712,14 @@ cur_state_store(struct device *dev, struct device_attribute *attr, ...@@ -712,11 +712,14 @@ cur_state_store(struct device *dev, struct device_attribute *attr,
if ((long)state < 0) if ((long)state < 0)
return -EINVAL; return -EINVAL;
mutex_lock(&cdev->lock);
result = cdev->ops->set_cur_state(cdev, state); result = cdev->ops->set_cur_state(cdev, state);
if (result) if (!result)
return result;
thermal_cooling_device_stats_update(cdev, state); thermal_cooling_device_stats_update(cdev, state);
return count;
mutex_unlock(&cdev->lock);
return result ? result : count;
} }
static struct device_attribute static struct device_attribute
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment