Commit 6b8526d3 authored by Corey Minyard's avatar Corey Minyard

ipmi:ssif: Handle a possible NULL pointer reference

In error cases a NULL can be passed to memcpy.  The length will always
be zero, so it doesn't really matter, but go ahead and check for NULL,
anyway, to be more precise and avoid static analysis errors.
Reported-by: default avatarkbuild test robot <lkp@intel.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 380665be
...@@ -775,10 +775,14 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result, ...@@ -775,10 +775,14 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result,
flags = ipmi_ssif_lock_cond(ssif_info, &oflags); flags = ipmi_ssif_lock_cond(ssif_info, &oflags);
msg = ssif_info->curr_msg; msg = ssif_info->curr_msg;
if (msg) { if (msg) {
if (data) {
if (len > IPMI_MAX_MSG_LENGTH)
len = IPMI_MAX_MSG_LENGTH;
memcpy(msg->rsp, data, len);
} else {
len = 0;
}
msg->rsp_size = len; msg->rsp_size = len;
if (msg->rsp_size > IPMI_MAX_MSG_LENGTH)
msg->rsp_size = IPMI_MAX_MSG_LENGTH;
memcpy(msg->rsp, data, msg->rsp_size);
ssif_info->curr_msg = NULL; ssif_info->curr_msg = NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment