Commit 6bbe1065 authored by Nícolas F. R. A. Prado's avatar Nícolas F. R. A. Prado Committed by Mathieu Poirier

dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x

Commit ca23ecfd ("remoteproc/mediatek: support L1TCM") added support
for the l1tcm memory region on the MT8192 SCP, adding a new da_to_va
callback that handles l1tcm while keeping the old one for
back-compatibility with MT8183. However, since the mt8192 compatible was
missing from the dt-binding, the accompanying dt-binding commit
503c64cc ("dt-bindings: remoteproc: mediatek: add L1TCM memory region")
mistakenly added this reg as if it were for mt8183. And later
it became common to all platforms as their compatibles were added.

Fix the dt-binding so that the l1tcm reg can be present only on the
supported platforms: mt8192 and mt8195.

Fixes: 503c64cc ("dt-bindings: remoteproc: mediatek: add L1TCM memory region")
Signed-off-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220511195452.871897-2-nfraprado@collabora.comSigned-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent be1de12c
...@@ -23,11 +23,13 @@ properties: ...@@ -23,11 +23,13 @@ properties:
reg: reg:
description: description:
Should contain the address ranges for memory regions SRAM, CFG, and Should contain the address ranges for memory regions SRAM, CFG, and,
L1TCM. on some platforms, L1TCM.
minItems: 2
maxItems: 3 maxItems: 3
reg-names: reg-names:
minItems: 2
items: items:
- const: sram - const: sram
- const: cfg - const: cfg
...@@ -57,17 +59,31 @@ required: ...@@ -57,17 +59,31 @@ required:
- reg - reg
- reg-names - reg-names
if: allOf:
- if:
properties: properties:
compatible: compatible:
enum: enum:
- mediatek,mt8183-scp - mediatek,mt8183-scp
- mediatek,mt8192-scp - mediatek,mt8192-scp
then: then:
required: required:
- clocks - clocks
- clock-names - clock-names
- if:
properties:
compatible:
enum:
- mediatek,mt8183-scp
- mediatek,mt8186-scp
then:
properties:
reg:
maxItems: 2
reg-names:
maxItems: 2
additionalProperties: additionalProperties:
type: object type: object
description: description:
...@@ -86,10 +102,10 @@ additionalProperties: ...@@ -86,10 +102,10 @@ additionalProperties:
examples: examples:
- | - |
#include <dt-bindings/clock/mt8183-clk.h> #include <dt-bindings/clock/mt8192-clk.h>
scp@10500000 { scp@10500000 {
compatible = "mediatek,mt8183-scp"; compatible = "mediatek,mt8192-scp";
reg = <0x10500000 0x80000>, reg = <0x10500000 0x80000>,
<0x10700000 0x8000>, <0x10700000 0x8000>,
<0x10720000 0xe0000>; <0x10720000 0xe0000>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment