Commit 6d40500a authored by Vivek Gautam's avatar Vivek Gautam Committed by Greg Kroah-Hartman

usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs

On enabling CONFIG_OF_SELFTEST which enables CONFIG_OF_DYNAMIC,
we found out that while getting PHYs for the controller we were
doing an extra of_node_put on the child node in our routines -
exynos_e/ohci_get_phy().
This child is however already put by of_get_next_available_child()
which does a of_node_put() on the "prev" node. So there's no point
in putting the same node again in our routine.
Reported-by: default avatarDaniel Drake <drake@endlessm.com>
Signed-off-by: default avatarVivek Gautam <gautam.vivek@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 61fbe96c
...@@ -74,7 +74,6 @@ static int exynos_ehci_get_phy(struct device *dev, ...@@ -74,7 +74,6 @@ static int exynos_ehci_get_phy(struct device *dev,
phy = devm_of_phy_get(dev, child, NULL); phy = devm_of_phy_get(dev, child, NULL);
exynos_ehci->phy[phy_number] = phy; exynos_ehci->phy[phy_number] = phy;
of_node_put(child);
if (IS_ERR(phy)) { if (IS_ERR(phy)) {
ret = PTR_ERR(phy); ret = PTR_ERR(phy);
if (ret == -EPROBE_DEFER) { if (ret == -EPROBE_DEFER) {
......
...@@ -63,7 +63,6 @@ static int exynos_ohci_get_phy(struct device *dev, ...@@ -63,7 +63,6 @@ static int exynos_ohci_get_phy(struct device *dev,
phy = devm_of_phy_get(dev, child, NULL); phy = devm_of_phy_get(dev, child, NULL);
exynos_ohci->phy[phy_number] = phy; exynos_ohci->phy[phy_number] = phy;
of_node_put(child);
if (IS_ERR(phy)) { if (IS_ERR(phy)) {
ret = PTR_ERR(phy); ret = PTR_ERR(phy);
if (ret == -EPROBE_DEFER) { if (ret == -EPROBE_DEFER) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment