Commit 6d56ab93 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Jeff Garzik

[PATCH] Dereference in tokenring/olympic.c

hi,

coverity found (bug id #225) that we might call free_netdev()
with NULL argument, when alloc_trdev() fails. This patch
changes the goto, so we dont call free_netdev() for
dev == NULL.
Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent a192491a
...@@ -217,7 +217,7 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device ...@@ -217,7 +217,7 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device
dev = alloc_trdev(sizeof(struct olympic_private)) ; dev = alloc_trdev(sizeof(struct olympic_private)) ;
if (!dev) { if (!dev) {
i = -ENOMEM; i = -ENOMEM;
goto op_free_dev; goto op_release_dev;
} }
olympic_priv = dev->priv ; olympic_priv = dev->priv ;
...@@ -282,8 +282,8 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device ...@@ -282,8 +282,8 @@ static int __devinit olympic_probe(struct pci_dev *pdev, const struct pci_device
if (olympic_priv->olympic_lap) if (olympic_priv->olympic_lap)
iounmap(olympic_priv->olympic_lap); iounmap(olympic_priv->olympic_lap);
op_free_dev:
free_netdev(dev); free_netdev(dev);
op_release_dev:
pci_release_regions(pdev); pci_release_regions(pdev);
op_disable_dev: op_disable_dev:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment