Commit 706b7761 authored by Thomas Zimmermann's avatar Thomas Zimmermann Committed by Alex Deucher

drm/mgag200: Replace ttm_bo_unref with ttm_bo_put

The function ttm_bo_put releases a reference to a TTM buffer object. The
function's name is more aligned to the Linux kernel convention of naming
ref-counting function _get and _put.

A call to ttm_bo_unref takes the address of the TTM BO object's pointer and
clears the pointer's value to NULL. This is not necessary in most cases and
sometimes even worked around by the calling code. A call to ttm_bo_put only
releases the reference without clearing the pointer.

The current behaviour of cleaning the pointer is kept in the calling code,
but should be removed if not required in a later patch.
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarHuang Rui <ray.huang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6034d9d4
...@@ -318,13 +318,9 @@ int mgag200_dumb_create(struct drm_file *file, ...@@ -318,13 +318,9 @@ int mgag200_dumb_create(struct drm_file *file,
static void mgag200_bo_unref(struct mgag200_bo **bo) static void mgag200_bo_unref(struct mgag200_bo **bo)
{ {
struct ttm_buffer_object *tbo;
if ((*bo) == NULL) if ((*bo) == NULL)
return; return;
ttm_bo_put(&((*bo)->bo));
tbo = &((*bo)->bo);
ttm_bo_unref(&tbo);
*bo = NULL; *bo = NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment