Commit 71fc156f authored by Alexei Starovoitov's avatar Alexei Starovoitov

Merge branch 'xdp1-improvements'

Matteo Croce says:

====================
Small improvements to improve the readability and easiness
to use of the xdp1 sample.
====================
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parents 9ffd05d9 dc378a1a
...@@ -15,6 +15,7 @@ ...@@ -15,6 +15,7 @@
#include <unistd.h> #include <unistd.h>
#include <libgen.h> #include <libgen.h>
#include <sys/resource.h> #include <sys/resource.h>
#include <net/if.h>
#include "bpf_util.h" #include "bpf_util.h"
#include "bpf/bpf.h" #include "bpf/bpf.h"
...@@ -34,26 +35,24 @@ static void int_exit(int sig) ...@@ -34,26 +35,24 @@ static void int_exit(int sig)
static void poll_stats(int map_fd, int interval) static void poll_stats(int map_fd, int interval)
{ {
unsigned int nr_cpus = bpf_num_possible_cpus(); unsigned int nr_cpus = bpf_num_possible_cpus();
const unsigned int nr_keys = 256; __u64 values[nr_cpus], prev[UINT8_MAX] = { 0 };
__u64 values[nr_cpus], prev[nr_keys][nr_cpus];
__u32 key;
int i; int i;
memset(prev, 0, sizeof(prev));
while (1) { while (1) {
__u32 key = UINT32_MAX;
sleep(interval); sleep(interval);
for (key = 0; key < nr_keys; key++) { while (bpf_map_get_next_key(map_fd, &key, &key) != -1) {
__u64 sum = 0; __u64 sum = 0;
assert(bpf_map_lookup_elem(map_fd, &key, values) == 0); assert(bpf_map_lookup_elem(map_fd, &key, values) == 0);
for (i = 0; i < nr_cpus; i++) for (i = 0; i < nr_cpus; i++)
sum += (values[i] - prev[key][i]); sum += values[i];
if (sum) if (sum > prev[key])
printf("proto %u: %10llu pkt/s\n", printf("proto %u: %10llu pkt/s\n",
key, sum / interval); key, (sum - prev[key]) / interval);
memcpy(prev[key], values, sizeof(values)); prev[key] = sum;
} }
} }
} }
...@@ -61,7 +60,7 @@ static void poll_stats(int map_fd, int interval) ...@@ -61,7 +60,7 @@ static void poll_stats(int map_fd, int interval)
static void usage(const char *prog) static void usage(const char *prog)
{ {
fprintf(stderr, fprintf(stderr,
"usage: %s [OPTS] IFINDEX\n\n" "usage: %s [OPTS] IFACE\n\n"
"OPTS:\n" "OPTS:\n"
" -S use skb-mode\n" " -S use skb-mode\n"
" -N enforce native mode\n", " -N enforce native mode\n",
...@@ -104,7 +103,11 @@ int main(int argc, char **argv) ...@@ -104,7 +103,11 @@ int main(int argc, char **argv)
return 1; return 1;
} }
ifindex = strtoul(argv[optind], NULL, 0); ifindex = if_nametoindex(argv[1]);
if (!ifindex) {
perror("if_nametoindex");
return 1;
}
snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]); snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]);
prog_load_attr.file = filename; prog_load_attr.file = filename;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment