Commit 721066df authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar

x86/mm/cpa: Fix cpa_flush_array() TLB invalidation

In commit:

  a7295fd5 ("x86/mm/cpa: Use flush_tlb_kernel_range()")

I misread the CAP array code and incorrectly used
tlb_flush_kernel_range(), resulting in missing TLB flushes and
consequent failures.

Instead do a full invalidate in this case -- for now.
Reported-by: default avatarStDenis, Tom <Tom.StDenis@amd.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dave.hansen@intel.com
Fixes: a7295fd5 ("x86/mm/cpa: Use flush_tlb_kernel_range()")
Link: http://lkml.kernel.org/r/20181203171043.089868285@infradead.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent cd01544a
...@@ -285,20 +285,16 @@ static void cpa_flush_all(unsigned long cache) ...@@ -285,20 +285,16 @@ static void cpa_flush_all(unsigned long cache)
on_each_cpu(__cpa_flush_all, (void *) cache, 1); on_each_cpu(__cpa_flush_all, (void *) cache, 1);
} }
static bool __cpa_flush_range(unsigned long start, int numpages, int cache) static bool __inv_flush_all(int cache)
{ {
BUG_ON(irqs_disabled() && !early_boot_irqs_disabled); BUG_ON(irqs_disabled() && !early_boot_irqs_disabled);
WARN_ON(PAGE_ALIGN(start) != start);
if (cache && !static_cpu_has(X86_FEATURE_CLFLUSH)) { if (cache && !static_cpu_has(X86_FEATURE_CLFLUSH)) {
cpa_flush_all(cache); cpa_flush_all(cache);
return true; return true;
} }
flush_tlb_kernel_range(start, start + PAGE_SIZE * numpages); return false;
return !cache;
} }
static void cpa_flush_range(unsigned long start, int numpages, int cache) static void cpa_flush_range(unsigned long start, int numpages, int cache)
...@@ -306,7 +302,14 @@ static void cpa_flush_range(unsigned long start, int numpages, int cache) ...@@ -306,7 +302,14 @@ static void cpa_flush_range(unsigned long start, int numpages, int cache)
unsigned int i, level; unsigned int i, level;
unsigned long addr; unsigned long addr;
if (__cpa_flush_range(start, numpages, cache)) WARN_ON(PAGE_ALIGN(start) != start);
if (__inv_flush_all(cache))
return;
flush_tlb_kernel_range(start, start + PAGE_SIZE * numpages);
if (!cache)
return; return;
/* /*
...@@ -332,7 +335,12 @@ static void cpa_flush_array(unsigned long baddr, unsigned long *start, ...@@ -332,7 +335,12 @@ static void cpa_flush_array(unsigned long baddr, unsigned long *start,
{ {
unsigned int i, level; unsigned int i, level;
if (__cpa_flush_range(baddr, numpages, cache)) if (__inv_flush_all(cache))
return;
flush_tlb_all();
if (!cache)
return; return;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment