Commit 72fcde96 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Linus Torvalds

Ignore bogus ACPI info for offline CPUs

Booting a SMP kernel with maxcpus=1 on a SMP system leads to a hard hang,
because ACPI ignores the maxcpus setting and sends timer broadcast info for
the offline CPUs.  This results in a stuck for ever call to
smp_call_function_single() on an offline CPU.

Ignore the bogus information and print a kernel error to remind ACPI
folks to fix it.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 88f18ba0
...@@ -243,11 +243,18 @@ void tick_broadcast_on_off(unsigned long reason, int *oncpu) ...@@ -243,11 +243,18 @@ void tick_broadcast_on_off(unsigned long reason, int *oncpu)
{ {
int cpu = get_cpu(); int cpu = get_cpu();
if (!cpu_isset(*oncpu, cpu_online_map)) {
printk(KERN_ERR "tick-braodcast: ignoring broadcast for "
"offline CPU #%d\n", *oncpu);
} else {
if (cpu == *oncpu) if (cpu == *oncpu)
tick_do_broadcast_on_off(&reason); tick_do_broadcast_on_off(&reason);
else else
smp_call_function_single(*oncpu, tick_do_broadcast_on_off, smp_call_function_single(*oncpu,
tick_do_broadcast_on_off,
&reason, 1, 1); &reason, 1, 1);
}
put_cpu(); put_cpu();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment