Commit 737912e1 authored by Bart Westgeest's avatar Bart Westgeest Committed by Greg Kroah-Hartman

staging: usbip: fix to prevent potentially using uninitialized spinlock

The stub_probe function can be called as soon as the stub_driver is
registered. This can lead to the busid_table_lock being used before it
is initialized. Moved calling the init_busid_table function (which
initalizes this spinlock) to be called earlier in the init function to
prevent this from happening.
Signed-off-by: default avatarBart Westgeest <bart@elbrys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c0029f0
...@@ -246,8 +246,9 @@ static int __init usbip_host_init(void) ...@@ -246,8 +246,9 @@ static int __init usbip_host_init(void)
{ {
int ret; int ret;
stub_priv_cache = KMEM_CACHE(stub_priv, SLAB_HWCACHE_ALIGN); init_busid_table();
stub_priv_cache = KMEM_CACHE(stub_priv, SLAB_HWCACHE_ALIGN);
if (!stub_priv_cache) { if (!stub_priv_cache) {
pr_err("kmem_cache_create failed\n"); pr_err("kmem_cache_create failed\n");
return -ENOMEM; return -ENOMEM;
...@@ -266,7 +267,6 @@ static int __init usbip_host_init(void) ...@@ -266,7 +267,6 @@ static int __init usbip_host_init(void)
goto err_create_file; goto err_create_file;
} }
init_busid_table();
pr_info(DRIVER_DESC " v" USBIP_VERSION "\n"); pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment