Commit 77f4396e authored by Fabio Baltieri's avatar Fabio Baltieri Committed by Felipe Balbi

usb: phy: ab8500-usb: fix last notifier arguments

Fix last ab->phy.notifier call to use vbus_draw as notifier argument, as
that's used in ab8500_charger to control charging current.

Also drop a related TODO comment, and the additional
ux500_musb_set_vbus(musb, 0), as with this patch it was causing an
erratic behaviour of gadget ep0 state machine.
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarFabio Baltieri <fabio.baltieri@linaro.org>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent f5ef7b42
...@@ -114,7 +114,6 @@ static int musb_otg_notifications(struct notifier_block *nb, ...@@ -114,7 +114,6 @@ static int musb_otg_notifications(struct notifier_block *nb,
break; break;
case UX500_MUSB_VBUS: case UX500_MUSB_VBUS:
dev_dbg(musb->controller, "VBUS Connect\n"); dev_dbg(musb->controller, "VBUS Connect\n");
ux500_musb_set_vbus(musb, 0);
break; break;
case UX500_MUSB_NONE: case UX500_MUSB_NONE:
dev_dbg(musb->controller, "VBUS Disconnect\n"); dev_dbg(musb->controller, "VBUS Disconnect\n");
......
...@@ -578,16 +578,12 @@ static int ab8500_usb_set_power(struct usb_phy *phy, unsigned mA) ...@@ -578,16 +578,12 @@ static int ab8500_usb_set_power(struct usb_phy *phy, unsigned mA)
ab->vbus_draw = mA; ab->vbus_draw = mA;
if (mA)
atomic_notifier_call_chain(&ab->phy.notifier, atomic_notifier_call_chain(&ab->phy.notifier,
UX500_MUSB_ENUMERATED, ab->phy.otg->gadget); UX500_MUSB_VBUS, &ab->vbus_draw);
return 0; return 0;
} }
/* TODO: Implement some way for charging or other drivers to read
* ab->vbus_draw.
*/
static int ab8500_usb_set_suspend(struct usb_phy *x, int suspend) static int ab8500_usb_set_suspend(struct usb_phy *x, int suspend)
{ {
/* TODO */ /* TODO */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment