Commit 78af7920 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Andrew Morton

s390/traps: only define is_valid_bugaddr() under CONFIG_GENERIC_BUG

When building with -Wmissing-prototypes without CONFIG_GENERIC_BUG, there
is a warning about a missing prototype for is_valid_bugaddr():

  arch/s390/kernel/traps.c:46:5: warning: no previous prototype for 'is_valid_bugaddr' [-Wmissing-prototypes]
     46 | int is_valid_bugaddr(unsigned long addr)
        |     ^~~~~~~~~~~~~~~~

The prototype is only declared with CONFIG_GENERIC_BUG, so only define the
function under the same condition to clear up the warning, which matches
other architectures.

Link: https://lkml.kernel.org/r/20231130-s390-missing-prototypes-v1-2-799d3cf07fb7@kernel.orgSigned-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarAlexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Jan Höppner <hoeppner@linux.ibm.com>
Cc: Stefan Haberland <sth@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c0706cfc
...@@ -43,10 +43,12 @@ static inline void __user *get_trap_ip(struct pt_regs *regs) ...@@ -43,10 +43,12 @@ static inline void __user *get_trap_ip(struct pt_regs *regs)
return (void __user *) (address - (regs->int_code >> 16)); return (void __user *) (address - (regs->int_code >> 16));
} }
#ifdef CONFIG_GENERIC_BUG
int is_valid_bugaddr(unsigned long addr) int is_valid_bugaddr(unsigned long addr)
{ {
return 1; return 1;
} }
#endif
void do_report_trap(struct pt_regs *regs, int si_signo, int si_code, char *str) void do_report_trap(struct pt_regs *regs, int si_signo, int si_code, char *str)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment