Commit 797eaed4 authored by Lachlan McIlroy's avatar Lachlan McIlroy

[XFS] Remove unnecessary assertion

Hit this assert because an inode was tagged with XFS_ICI_RECLAIM_TAG but
not XFS_IRECLAIMABLE|XFS_IRECLAIM.  This is because xfs_iget_cache_hit()
first clears XFS_IRECLAIMABLE and then calls __xfs_inode_clear_reclaim_tag()
while only holding the pag_ici_lock in read mode so we can race with
xfs_reclaim_inodes_ag().  Looks like xfs_reclaim_inodes_ag() will do the
right thing anyway so just remove the assert.

Thanks to Christoph for pointing out where the problem was.
Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
Reviewed-by: default avatarChristoph Hellwig <hch@infradead.org>
parent a5b429d4
...@@ -707,8 +707,6 @@ xfs_reclaim_inodes_ag( ...@@ -707,8 +707,6 @@ xfs_reclaim_inodes_ag(
break; break;
} }
ASSERT(xfs_iflags_test(ip, (XFS_IRECLAIMABLE|XFS_IRECLAIM)));
/* ignore if already under reclaim */ /* ignore if already under reclaim */
if (xfs_iflags_test(ip, XFS_IRECLAIM)) { if (xfs_iflags_test(ip, XFS_IRECLAIM)) {
read_unlock(&pag->pag_ici_lock); read_unlock(&pag->pag_ici_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment