Commit 7a842ed6 authored by Sachin Kamat's avatar Sachin Kamat Committed by Jonathan Cameron

iio: gyro: st_gyro: Use devm_iio_device_alloc

Using devm_iio_device_alloc makes code simpler.
Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Cc: Denis Ciocca <denis.ciocca@st.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent d243b3c0
...@@ -366,7 +366,6 @@ void st_gyro_common_remove(struct iio_dev *indio_dev) ...@@ -366,7 +366,6 @@ void st_gyro_common_remove(struct iio_dev *indio_dev)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_gyro_deallocate_ring(indio_dev); st_gyro_deallocate_ring(indio_dev);
} }
iio_device_free(indio_dev);
} }
EXPORT_SYMBOL(st_gyro_common_remove); EXPORT_SYMBOL(st_gyro_common_remove);
......
...@@ -25,11 +25,9 @@ static int st_gyro_i2c_probe(struct i2c_client *client, ...@@ -25,11 +25,9 @@ static int st_gyro_i2c_probe(struct i2c_client *client,
struct st_sensor_data *gdata; struct st_sensor_data *gdata;
int err; int err;
indio_dev = iio_device_alloc(sizeof(*gdata)); indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*gdata));
if (indio_dev == NULL) { if (!indio_dev)
err = -ENOMEM; return -ENOMEM;
goto iio_device_alloc_error;
}
gdata = iio_priv(indio_dev); gdata = iio_priv(indio_dev);
gdata->dev = &client->dev; gdata->dev = &client->dev;
...@@ -39,14 +37,9 @@ static int st_gyro_i2c_probe(struct i2c_client *client, ...@@ -39,14 +37,9 @@ static int st_gyro_i2c_probe(struct i2c_client *client,
err = st_gyro_common_probe(indio_dev, err = st_gyro_common_probe(indio_dev,
(struct st_sensors_platform_data *)&gyro_pdata); (struct st_sensors_platform_data *)&gyro_pdata);
if (err < 0) if (err < 0)
goto st_gyro_common_probe_error; return err;
return 0; return 0;
st_gyro_common_probe_error:
iio_device_free(indio_dev);
iio_device_alloc_error:
return err;
} }
static int st_gyro_i2c_remove(struct i2c_client *client) static int st_gyro_i2c_remove(struct i2c_client *client)
......
...@@ -24,11 +24,9 @@ static int st_gyro_spi_probe(struct spi_device *spi) ...@@ -24,11 +24,9 @@ static int st_gyro_spi_probe(struct spi_device *spi)
struct st_sensor_data *gdata; struct st_sensor_data *gdata;
int err; int err;
indio_dev = iio_device_alloc(sizeof(*gdata)); indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*gdata));
if (indio_dev == NULL) { if (!indio_dev)
err = -ENOMEM; return -ENOMEM;
goto iio_device_alloc_error;
}
gdata = iio_priv(indio_dev); gdata = iio_priv(indio_dev);
gdata->dev = &spi->dev; gdata->dev = &spi->dev;
...@@ -38,14 +36,9 @@ static int st_gyro_spi_probe(struct spi_device *spi) ...@@ -38,14 +36,9 @@ static int st_gyro_spi_probe(struct spi_device *spi)
err = st_gyro_common_probe(indio_dev, err = st_gyro_common_probe(indio_dev,
(struct st_sensors_platform_data *)&gyro_pdata); (struct st_sensors_platform_data *)&gyro_pdata);
if (err < 0) if (err < 0)
goto st_gyro_common_probe_error; return err;
return 0; return 0;
st_gyro_common_probe_error:
iio_device_free(indio_dev);
iio_device_alloc_error:
return err;
} }
static int st_gyro_spi_remove(struct spi_device *spi) static int st_gyro_spi_remove(struct spi_device *spi)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment