Commit 7b9e2de1 authored by Wei Yang's avatar Wei Yang Committed by Linus Torvalds

mm/swapfile.c: omit a duplicate code by compare tmp and max first

There are two duplicate code to handle the case when there is no available
swap entry.  To avoid this, we can compare tmp and max first and let the
second guard do its job.

No functional change is expected.
Signed-off-by: default avatarWei Yang <richard.weiyang@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatar"Huang, Ying" <ying.huang@intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Hugh Dickins <hughd@google.com>
Link: http://lkml.kernel.org/r/20200421213824.8099-3-richard.weiyang@gmail.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fdff1deb
...@@ -629,10 +629,7 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si, ...@@ -629,10 +629,7 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si,
tmp = cluster->next; tmp = cluster->next;
max = min_t(unsigned long, si->max, max = min_t(unsigned long, si->max,
(cluster_next(&cluster->index) + 1) * SWAPFILE_CLUSTER); (cluster_next(&cluster->index) + 1) * SWAPFILE_CLUSTER);
if (tmp >= max) { if (tmp < max) {
cluster_set_null(&cluster->index);
goto new_cluster;
}
ci = lock_cluster(si, tmp); ci = lock_cluster(si, tmp);
while (tmp < max) { while (tmp < max) {
if (!si->swap_map[tmp]) if (!si->swap_map[tmp])
...@@ -640,6 +637,7 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si, ...@@ -640,6 +637,7 @@ static bool scan_swap_map_try_ssd_cluster(struct swap_info_struct *si,
tmp++; tmp++;
} }
unlock_cluster(ci); unlock_cluster(ci);
}
if (tmp >= max) { if (tmp >= max) {
cluster_set_null(&cluster->index); cluster_set_null(&cluster->index);
goto new_cluster; goto new_cluster;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment