Commit 7bd1dfa4 authored by Netanel Belgazal's avatar Netanel Belgazal Committed by Kleber Sacilotto de Souza

net: ena: add statistics for missed tx packets

BugLink: http://bugs.launchpad.net/bugs/1792044

Add a new statistic to ethtool stats that show the number of packets
without transmit acknowledgement from ENA device.
Signed-off-by: default avatarNetanel Belgazal <netanel@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
(cherry picked from commit 11095fdb)
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
Acked-by: default avatarAcked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: default avatarBrad Figg <brad.figg@canonical.com>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 2e4ae3d7
...@@ -81,6 +81,7 @@ static const struct ena_stats ena_stats_tx_strings[] = { ...@@ -81,6 +81,7 @@ static const struct ena_stats ena_stats_tx_strings[] = {
ENA_STAT_TX_ENTRY(doorbells), ENA_STAT_TX_ENTRY(doorbells),
ENA_STAT_TX_ENTRY(prepare_ctx_err), ENA_STAT_TX_ENTRY(prepare_ctx_err),
ENA_STAT_TX_ENTRY(bad_req_id), ENA_STAT_TX_ENTRY(bad_req_id),
ENA_STAT_TX_ENTRY(missed_tx),
}; };
static const struct ena_stats ena_stats_rx_strings[] = { static const struct ena_stats ena_stats_rx_strings[] = {
......
...@@ -2636,7 +2636,7 @@ static int check_missing_comp_in_queue(struct ena_adapter *adapter, ...@@ -2636,7 +2636,7 @@ static int check_missing_comp_in_queue(struct ena_adapter *adapter,
struct ena_tx_buffer *tx_buf; struct ena_tx_buffer *tx_buf;
unsigned long last_jiffies; unsigned long last_jiffies;
u32 missed_tx = 0; u32 missed_tx = 0;
int i; int i, rc = 0;
for (i = 0; i < tx_ring->ring_size; i++) { for (i = 0; i < tx_ring->ring_size; i++) {
tx_buf = &tx_ring->tx_buffer_info[i]; tx_buf = &tx_ring->tx_buffer_info[i];
...@@ -2650,6 +2650,8 @@ static int check_missing_comp_in_queue(struct ena_adapter *adapter, ...@@ -2650,6 +2650,8 @@ static int check_missing_comp_in_queue(struct ena_adapter *adapter,
tx_buf->print_once = 1; tx_buf->print_once = 1;
missed_tx++; missed_tx++;
}
}
if (unlikely(missed_tx > adapter->missing_tx_completion_threshold)) { if (unlikely(missed_tx > adapter->missing_tx_completion_threshold)) {
netif_err(adapter, tx_err, adapter->netdev, netif_err(adapter, tx_err, adapter->netdev,
...@@ -2659,12 +2661,14 @@ static int check_missing_comp_in_queue(struct ena_adapter *adapter, ...@@ -2659,12 +2661,14 @@ static int check_missing_comp_in_queue(struct ena_adapter *adapter,
adapter->reset_reason = adapter->reset_reason =
ENA_REGS_RESET_MISS_TX_CMPL; ENA_REGS_RESET_MISS_TX_CMPL;
set_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags); set_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags);
return -EIO; rc = -EIO;
}
}
} }
return 0; u64_stats_update_begin(&tx_ring->syncp);
tx_ring->tx_stats.missed_tx = missed_tx;
u64_stats_update_end(&tx_ring->syncp);
return rc;
} }
static void check_for_missing_tx_completions(struct ena_adapter *adapter) static void check_for_missing_tx_completions(struct ena_adapter *adapter)
......
...@@ -182,6 +182,7 @@ struct ena_stats_tx { ...@@ -182,6 +182,7 @@ struct ena_stats_tx {
u64 tx_poll; u64 tx_poll;
u64 doorbells; u64 doorbells;
u64 bad_req_id; u64 bad_req_id;
u64 missed_tx;
}; };
struct ena_stats_rx { struct ena_stats_rx {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment