Commit 7e15b584 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Kelsey Skunberg

iio: imu: adis16400: release allocated memory on failure

CVE-2019-19060

In adis_update_scan_mode, if allocation for adis->buffer fails,
previously allocated adis->xfer needs to be released.
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
(backported from commit ab612b1d)
[PHLin: context adjustment]
Signed-off-by: default avatarPo-Hsu Lin <po-hsu.lin@canonical.com>
Acked-by: default avatarBenjamin M Romer <benjamin.romer@canonical.com>
Acked-by: default avatarSultan Alsawaf <sultan.alsawaf@canonical.com>
Signed-off-by: default avatarKelsey Skunberg <kelsey.skunberg@canonical.com>
parent b5372b8c
...@@ -39,8 +39,11 @@ int adis_update_scan_mode(struct iio_dev *indio_dev, ...@@ -39,8 +39,11 @@ int adis_update_scan_mode(struct iio_dev *indio_dev,
return -ENOMEM; return -ENOMEM;
adis->buffer = kzalloc(indio_dev->scan_bytes * 2, GFP_KERNEL); adis->buffer = kzalloc(indio_dev->scan_bytes * 2, GFP_KERNEL);
if (!adis->buffer) if (!adis->buffer) {
kfree(adis->xfer);
adis->xfer = NULL;
return -ENOMEM; return -ENOMEM;
}
rx = adis->buffer; rx = adis->buffer;
tx = rx + scan_count; tx = rx + scan_count;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment