Commit 7e1ff15b authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Thomas Gleixner

x86/platform/iosf_mbi: Source cleanup

 - Move the static variables to one place
 - Fix indentations in the header
 - Correct comments

No functional change.

[ tglx: Massaged changelog ]
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David E . Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1436366709-17683-5-git-send-email-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent b93fb9f6
...@@ -31,6 +31,7 @@ ...@@ -31,6 +31,7 @@
#define PCI_DEVICE_ID_BRASWELL 0x2280 #define PCI_DEVICE_ID_BRASWELL 0x2280
#define PCI_DEVICE_ID_QUARK_X1000 0x0958 #define PCI_DEVICE_ID_QUARK_X1000 0x0958
static struct pci_dev *mbi_pdev;
static DEFINE_SPINLOCK(iosf_mbi_lock); static DEFINE_SPINLOCK(iosf_mbi_lock);
static inline u32 iosf_mbi_form_mcr(u8 op, u8 port, u8 offset) static inline u32 iosf_mbi_form_mcr(u8 op, u8 port, u8 offset)
...@@ -38,8 +39,6 @@ static inline u32 iosf_mbi_form_mcr(u8 op, u8 port, u8 offset) ...@@ -38,8 +39,6 @@ static inline u32 iosf_mbi_form_mcr(u8 op, u8 port, u8 offset)
return (op << 24) | (port << 16) | (offset << 8) | MBI_ENABLE; return (op << 24) | (port << 16) | (offset << 8) | MBI_ENABLE;
} }
static struct pci_dev *mbi_pdev; /* one mbi device */
static int iosf_mbi_pci_read_mdr(u32 mcrx, u32 mcr, u32 *mdr) static int iosf_mbi_pci_read_mdr(u32 mcrx, u32 mcr, u32 *mdr)
{ {
int result; int result;
...@@ -104,7 +103,7 @@ int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr) ...@@ -104,7 +103,7 @@ int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
unsigned long flags; unsigned long flags;
int ret; int ret;
/*Access to the GFX unit is handled by GPU code */ /* Access to the GFX unit is handled by GPU code */
if (port == BT_MBI_UNIT_GFX) { if (port == BT_MBI_UNIT_GFX) {
WARN_ON(1); WARN_ON(1);
return -EPERM; return -EPERM;
...@@ -127,7 +126,7 @@ int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr) ...@@ -127,7 +126,7 @@ int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
unsigned long flags; unsigned long flags;
int ret; int ret;
/*Access to the GFX unit is handled by GPU code */ /* Access to the GFX unit is handled by GPU code */
if (port == BT_MBI_UNIT_GFX) { if (port == BT_MBI_UNIT_GFX) {
WARN_ON(1); WARN_ON(1);
return -EPERM; return -EPERM;
...@@ -151,7 +150,7 @@ int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask) ...@@ -151,7 +150,7 @@ int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
unsigned long flags; unsigned long flags;
int ret; int ret;
/*Access to the GFX unit is handled by GPU code */ /* Access to the GFX unit is handled by GPU code */
if (port == BT_MBI_UNIT_GFX) { if (port == BT_MBI_UNIT_GFX) {
WARN_ON(1); WARN_ON(1);
return -EPERM; return -EPERM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment