media: coda: fail S_SELECTION for read-only targets

v4l2-compliance complains if S_SELECTION returns 0 for read-only targets.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

drivers/media/platform/coda/coda-common.c

@@ -939,9 +939,10 @@ static int coda_s_selection(struct file *file, void *fh,
 	struct coda_ctx *ctx = fh_to_ctx(fh);
 	struct coda_q_data *q_data;
 
+	switch (s->target) {
+	case V4L2_SEL_TGT_CROP:
 		if (ctx->inst_type == CODA_INST_ENCODER &&
-	    s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT &&
-	    s->target == V4L2_SEL_TGT_CROP) {
+		    s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
 			q_data = get_q_data(ctx, s->type);
 			if (!q_data)
 				return -EINVAL;
@@ -963,8 +964,14 @@ static int coda_s_selection(struct file *file, void *fh,
 
 			return 0;
 		}
-
+		/* else fall through */
+	case V4L2_SEL_TGT_NATIVE_SIZE:
+	case V4L2_SEL_TGT_COMPOSE:
 		return coda_g_selection(file, fh, s);
+	default:
+		/* v4l2-compliance expects this to fail for read-only targets */
+		return -EINVAL;
+	}
 }
 
 static int coda_try_encoder_cmd(struct file *file, void *fh,